5242: Fix infinite loop r=Kerollmops a=dureuill
- Fix possible infinite loop by releasing `writer_receiver` as soon as writing to DB panics
- Demote panic to error log
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
5243: Update version for the next release (v1.12.4) in Cargo.toml r=dureuill a=meili-bot
⚠️ This PR is automatically generated. Check the new version is the expected one and Cargo.lock has been updated before merging.
Co-authored-by: dureuill <dureuill@users.noreply.github.com>
5227: Update version for the next release (v1.12.3) in Cargo.toml r=dureuill a=meili-bot
⚠️ This PR is automatically generated. Check the new version is the expected one and Cargo.lock has been updated before merging.
Co-authored-by: dureuill <dureuill@users.noreply.github.com>
5205: Incremental facets on v1.12 r=curquiza a=dureuill
# Pull Request
## Related issue
Fixes https://github.com/meilisearch/meilisearch/issues/5213
## What does this PR do?
- Add `new_incremental`module that computes incremental facet indexing for the new indexer
- Change heuristics for incremental vs bulk facet choice: under 1000 operations is now always incremental, over 100_000 operations is now always bulk)
- Add sanity checks in debug
## Future improvements
- Use multi ops from Roaring to decrease the number of allocations
- Consider removing or adding multiple levels at once instead of max once per update
- Consider using information about the tree structure + the operations that were done (e.g. only addition) to avoid recomputing the group from all children
- Consider making the algorithm parallel and looking into the roaring values to know which actually changed
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
5207: Update version for the next release (v1.12.2) in Cargo.toml r=dureuill a=meili-bot
⚠️ This PR is automatically generated. Check the new version is the expected one and Cargo.lock has been updated before merging.
Co-authored-by: dureuill <dureuill@users.noreply.github.com>
5192: Fix empty document addition r=irevoire a=irevoire
# Pull Request
## Related issue
Fixes#5190
## What does this PR do?
- Improve a test just to make sure this issue never arises again
- Fix the issue
For the reviewer: Calling `add_documents` with an empty `mmap` seems to work, but does it impact the perf in a significant way? /
Co-authored-by: Tamo <tamo@meilisearch.com>
5193: Update version for the next release (v1.12.1) in Cargo.toml r=irevoire a=meili-bot
⚠️ This PR is automatically generated. Check the new version is the expected one and Cargo.lock has been updated before merging.
Co-authored-by: curquiza <curquiza@users.noreply.github.com>
5159: Fix the New Indexer Spilling r=irevoire a=Kerollmops
Fix two bugs in the merging of the spilled caches. Thanks to `@ManyTheFish` and `@irevoire` 👏
Co-authored-by: Kerollmops <clement@meilisearch.com>
Co-authored-by: ManyTheFish <many@meilisearch.com>
