some warning fix

This commit is contained in:
Louis Dureuil 2024-11-07 10:06:07 +01:00
parent 03650e3217
commit e2138170ad
No known key found for this signature in database
3 changed files with 5 additions and 4 deletions

View File

@ -98,7 +98,7 @@ impl<'a, 'extractor> Extractor<'extractor> for EmbeddingExtractor<'a> {
let new_vectors = update.updated_vectors(&context.doc_alloc, self.embedders)?; let new_vectors = update.updated_vectors(&context.doc_alloc, self.embedders)?;
if let Some(new_vectors) = &new_vectors { if let Some(new_vectors) = &new_vectors {
unused_vectors_distribution.append(new_vectors); unused_vectors_distribution.append(new_vectors)?;
} }
for chunks in &mut all_chunks { for chunks in &mut all_chunks {
@ -187,7 +187,7 @@ impl<'a, 'extractor> Extractor<'extractor> for EmbeddingExtractor<'a> {
let new_vectors = let new_vectors =
insertion.inserted_vectors(&context.doc_alloc, self.embedders)?; insertion.inserted_vectors(&context.doc_alloc, self.embedders)?;
if let Some(new_vectors) = &new_vectors { if let Some(new_vectors) = &new_vectors {
unused_vectors_distribution.append(new_vectors); unused_vectors_distribution.append(new_vectors)?;
} }
for chunks in &mut all_chunks { for chunks in &mut all_chunks {
@ -343,6 +343,7 @@ impl<'a, 'extractor> Chunks<'a, 'extractor> {
res res
} }
#[allow(clippy::too_many_arguments)]
pub fn embed_chunks( pub fn embed_chunks(
texts: &mut BVec<'a, &'a str>, texts: &mut BVec<'a, &'a str>,
ids: &mut BVec<'a, DocumentId>, ids: &mut BVec<'a, DocumentId>,

View File

@ -594,7 +594,7 @@ impl<'de> Visitor<'de> for DeserrRawValueVisitor<'de> {
where where
A: serde::de::SeqAccess<'de>, A: serde::de::SeqAccess<'de>,
{ {
let mut raw_vec = raw_collections::RawVec::new_in(&self.alloc); let mut raw_vec = raw_collections::RawVec::new_in(self.alloc);
while let Some(next) = seq.next_element()? { while let Some(next) = seq.next_element()? {
raw_vec.push(next); raw_vec.push(next);
} }

View File

@ -6,7 +6,7 @@ use serde_json::value::RawValue;
use super::document_changes::{DocumentChangeContext, DocumentChanges, MostlySend, RefCellExt}; use super::document_changes::{DocumentChangeContext, DocumentChanges, MostlySend, RefCellExt};
use crate::documents::PrimaryKey; use crate::documents::PrimaryKey;
use crate::update::concurrent_available_ids::ConcurrentAvailableIds; use crate::update::concurrent_available_ids::ConcurrentAvailableIds;
use crate::update::new::document::{DocumentFromVersions, Versions}; use crate::update::new::document::Versions;
use crate::update::new::{DocumentChange, Insertion}; use crate::update::new::{DocumentChange, Insertion};
use crate::{Error, InternalError, Result, UserError}; use crate::{Error, InternalError, Result, UserError};