From e2138170adf9afd017ccea73a9bf939e3a20e931 Mon Sep 17 00:00:00 2001
From: Louis Dureuil <louis@meilisearch.com>
Date: Thu, 7 Nov 2024 10:06:07 +0100
Subject: [PATCH] some warning fix

---
 crates/milli/src/update/new/extract/vectors/mod.rs  | 5 +++--
 crates/milli/src/update/new/indexer/de.rs           | 2 +-
 crates/milli/src/update/new/indexer/partial_dump.rs | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/crates/milli/src/update/new/extract/vectors/mod.rs b/crates/milli/src/update/new/extract/vectors/mod.rs
index a5cf915e4..55121fb14 100644
--- a/crates/milli/src/update/new/extract/vectors/mod.rs
+++ b/crates/milli/src/update/new/extract/vectors/mod.rs
@@ -98,7 +98,7 @@ impl<'a, 'extractor> Extractor<'extractor> for EmbeddingExtractor<'a> {
                     let new_vectors = update.updated_vectors(&context.doc_alloc, self.embedders)?;
 
                     if let Some(new_vectors) = &new_vectors {
-                        unused_vectors_distribution.append(new_vectors);
+                        unused_vectors_distribution.append(new_vectors)?;
                     }
 
                     for chunks in &mut all_chunks {
@@ -187,7 +187,7 @@ impl<'a, 'extractor> Extractor<'extractor> for EmbeddingExtractor<'a> {
                     let new_vectors =
                         insertion.inserted_vectors(&context.doc_alloc, self.embedders)?;
                     if let Some(new_vectors) = &new_vectors {
-                        unused_vectors_distribution.append(new_vectors);
+                        unused_vectors_distribution.append(new_vectors)?;
                     }
 
                     for chunks in &mut all_chunks {
@@ -343,6 +343,7 @@ impl<'a, 'extractor> Chunks<'a, 'extractor> {
         res
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub fn embed_chunks(
         texts: &mut BVec<'a, &'a str>,
         ids: &mut BVec<'a, DocumentId>,
diff --git a/crates/milli/src/update/new/indexer/de.rs b/crates/milli/src/update/new/indexer/de.rs
index 94ab4c2c1..832aadd43 100644
--- a/crates/milli/src/update/new/indexer/de.rs
+++ b/crates/milli/src/update/new/indexer/de.rs
@@ -594,7 +594,7 @@ impl<'de> Visitor<'de> for DeserrRawValueVisitor<'de> {
     where
         A: serde::de::SeqAccess<'de>,
     {
-        let mut raw_vec = raw_collections::RawVec::new_in(&self.alloc);
+        let mut raw_vec = raw_collections::RawVec::new_in(self.alloc);
         while let Some(next) = seq.next_element()? {
             raw_vec.push(next);
         }
diff --git a/crates/milli/src/update/new/indexer/partial_dump.rs b/crates/milli/src/update/new/indexer/partial_dump.rs
index e58141af7..4984eb354 100644
--- a/crates/milli/src/update/new/indexer/partial_dump.rs
+++ b/crates/milli/src/update/new/indexer/partial_dump.rs
@@ -6,7 +6,7 @@ use serde_json::value::RawValue;
 use super::document_changes::{DocumentChangeContext, DocumentChanges, MostlySend, RefCellExt};
 use crate::documents::PrimaryKey;
 use crate::update::concurrent_available_ids::ConcurrentAvailableIds;
-use crate::update::new::document::{DocumentFromVersions, Versions};
+use crate::update::new::document::Versions;
 use crate::update::new::{DocumentChange, Insertion};
 use crate::{Error, InternalError, Result, UserError};