Resolve code modification suggestions

This commit is contained in:
Kerollmops 2021-05-31 15:22:50 +02:00
parent 5012cc3a32
commit 1c0a5cd136
No known key found for this signature in database
GPG Key ID: 92ADA4E935E71FA4
3 changed files with 0 additions and 4 deletions

View File

@ -240,9 +240,7 @@ impl FacetCondition {
let value = items.next().unwrap(); let value = items.next().unwrap();
let (result, svalue) = pest_parse(value); let (result, svalue) = pest_parse(value);
// TODO we must normalize instead of lowercase.
let svalue = svalue.to_lowercase(); let svalue = svalue.to_lowercase();
Ok(Operator(fid, Equal(result.ok(), svalue))) Ok(Operator(fid, Equal(result.ok(), svalue)))
} }

View File

@ -98,7 +98,6 @@ impl<'t, 'u, 'i> Facets<'t, 'u, 'i> {
self.index.put_string_faceted_documents_ids(self.wtxn, field_id, &string_documents_ids)?; self.index.put_string_faceted_documents_ids(self.wtxn, field_id, &string_documents_ids)?;
self.index.put_number_faceted_documents_ids(self.wtxn, field_id, &number_documents_ids)?; self.index.put_number_faceted_documents_ids(self.wtxn, field_id, &number_documents_ids)?;
// Store the
write_into_lmdb_database( write_into_lmdb_database(
self.wtxn, self.wtxn,
*self.index.facet_id_f64_docids.as_polymorph(), *self.index.facet_id_f64_docids.as_polymorph(),

View File

@ -816,7 +816,6 @@ fn extract_facet_values(value: &Value) -> (Vec<f64>, Vec<String>) {
output_numbers.push(float); output_numbers.push(float);
}, },
Value::String(string) => { Value::String(string) => {
// TODO must be normalized and not only lowercased.
let string = string.trim().to_lowercase(); let string = string.trim().to_lowercase();
output_strings.push(string); output_strings.push(string);
}, },