From 1c0a5cd136146e0b290445ed16130e48014402d8 Mon Sep 17 00:00:00 2001 From: Kerollmops Date: Mon, 31 May 2021 15:22:50 +0200 Subject: [PATCH] Resolve code modification suggestions --- milli/src/search/facet/facet_condition.rs | 2 -- milli/src/update/facets.rs | 1 - milli/src/update/index_documents/store.rs | 1 - 3 files changed, 4 deletions(-) diff --git a/milli/src/search/facet/facet_condition.rs b/milli/src/search/facet/facet_condition.rs index e7917df97..fd7053269 100644 --- a/milli/src/search/facet/facet_condition.rs +++ b/milli/src/search/facet/facet_condition.rs @@ -240,9 +240,7 @@ impl FacetCondition { let value = items.next().unwrap(); let (result, svalue) = pest_parse(value); - // TODO we must normalize instead of lowercase. let svalue = svalue.to_lowercase(); - Ok(Operator(fid, Equal(result.ok(), svalue))) } diff --git a/milli/src/update/facets.rs b/milli/src/update/facets.rs index af72133a2..f0eab6023 100644 --- a/milli/src/update/facets.rs +++ b/milli/src/update/facets.rs @@ -98,7 +98,6 @@ impl<'t, 'u, 'i> Facets<'t, 'u, 'i> { self.index.put_string_faceted_documents_ids(self.wtxn, field_id, &string_documents_ids)?; self.index.put_number_faceted_documents_ids(self.wtxn, field_id, &number_documents_ids)?; - // Store the write_into_lmdb_database( self.wtxn, *self.index.facet_id_f64_docids.as_polymorph(), diff --git a/milli/src/update/index_documents/store.rs b/milli/src/update/index_documents/store.rs index afc199293..4f65d77e1 100644 --- a/milli/src/update/index_documents/store.rs +++ b/milli/src/update/index_documents/store.rs @@ -816,7 +816,6 @@ fn extract_facet_values(value: &Value) -> (Vec, Vec) { output_numbers.push(float); }, Value::String(string) => { - // TODO must be normalized and not only lowercased. let string = string.trim().to_lowercase(); output_strings.push(string); },