meilisearch

mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-23 10:37:41 +08:00

History

bors[bot] 8ddec58430 Merge #3061 3061: Name spawned threads r=irevoire a=dureuill # Pull Request ## Related issue None, this is to improve debuggability ## What does this PR do? - This PR replaces the raw `thread::spawn(...)` calls by `thread::Builder::new().name(...).spawn(...).unwrap()` calls so that we can give meaningful names to threads. - This PR also setup the `rayon` thread pool to give a name to its threads. - This improves debuggability, as the thread names are reported by debuggers: <img width="411" alt="Capture d’écran 2022-11-16 à 10 26 27" src="https://user-images.githubusercontent.com/41078892/202141870-a88663aa-d2f8-494f-b4da-709fdbd072ba.png"> (screen showing vscode's debugger and its main/scheduler/indexing threads) ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Louis Dureuil <louis@meilisearch.com>	2022-11-16 14:25:32 +00:00
..
src	Merge #3061	2022-11-16 14:25:32 +00:00
Cargo.toml	Update version for the next release (v0.30.0) in Cargo.toml files	2022-10-27 11:35:44 +00:00

3061: Name spawned threads r=irevoire a=dureuill

# Pull Request

## Related issue
None, this is to improve debuggability

## What does this PR do?
- This PR replaces the raw `thread::spawn(...)` calls by `thread::Builder::new().name(...).spawn(...).unwrap()` calls so that we can give meaningful names to threads. 
- This PR also setup the `rayon` thread pool to give a name to its threads.
- This improves debuggability, as the thread names are reported by debuggers:

<img width="411" alt="Capture d’écran 2022-11-16 à 10 26 27" src="https://user-images.githubusercontent.com/41078892/202141870-a88663aa-d2f8-494f-b4da-709fdbd072ba.png">

(screen showing vscode's debugger and its main/scheduler/indexing threads)

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Louis Dureuil <louis@meilisearch.com>

2022-11-16 14:25:32 +00:00

src

Merge #3061

2022-11-16 14:25:32 +00:00

Cargo.toml

Update version for the next release (v0.30.0) in Cargo.toml files

2022-10-27 11:35:44 +00:00