snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-26 12:05:05 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity
bf66e97b48
meilisearch/milli/src
History
meili-bors[bot] bf66e97b48
Merge #3749 
3749: Fix back: sort error message r=ManyTheFish a=ManyTheFish

This PR reintroduces the error message modified in https://github.com/meilisearch/milli/pull/375.
However, this added double-quotes around `sort` in the message. I don't think another message contains double-quotes, so I have added a separate commit replacing the double-quotes with back-ticks, which seems more consistent with the other error messages, this last change can be reverted easily.

## Detailed changes
#### v1.2-rc0
```
The sort ranking rule must be specified in the ranking rules settings to use the sort parameter at search time.
```
#### [Reintroduce fix (previous and expected behavior)](23d1c86825)
```
You must specify where "sort" is listed in the rankingRules setting to use the sort parameter at search time
```
#### [Replace double-quotes with back-ticks (my suggestion)](4d691d071a)
```
You must specify where `sort` is listed in the rankingRules setting to use the sort parameter at search time
```

## Related

Fixes #3722

## Reviewers

- technical review: `@irevoire`
- to validate the replacement: `@macraig`

Co-authored-by: ManyTheFish <many@meilisearch.com>
2023-05-15 14:55:51 +00:00
..
documents makes kero happy 2023-03-13 16:51:11 +01:00
facet update milli with the new parser_filter 2021-11-04 15:02:36 +01:00
heed_codec Cargo fmt 2023-05-03 12:21:58 +02:00
search Compute split words derivations of terms that don't accept typos 2023-05-10 13:31:19 +02:00
snapshots/index.rs throw an error on unknown fields specified in the _geo field 2023-01-24 12:23:24 +01:00
update Use the writemap flag to reduce the memory usage 2023-05-15 10:15:33 +02:00
asc_desc.rs fmt 2023-03-30 23:37:26 +02:00
criterion.rs update the syntax of the geoboundingbox filter to uses brackets instead of parens around lat and lng 2023-02-06 16:50:27 +01:00
error.rs Change double-quotes by back-ticks in sort error message 2023-05-15 11:10:36 +02:00
external_documents_ids.rs Fix hard-deletion of an external id that was soft-deleted 2022-12-20 15:33:31 +01:00
fields_ids_map.rs Fixes for clippy bringing us down to 18 remaining issues. 2022-10-25 20:49:02 +02:00
index.rs Expose a flag to enable the MDB_WRITEMAP flag 2023-05-15 11:38:43 +02:00
lib.rs Implements the geo-sort ranking rule 2023-04-29 11:02:16 +02:00
proximity.rs Remove limit of 1000 position per attribute 2021-10-12 10:10:50 +02:00
snapshot_tests.rs Merge remote-tracking branch 'origin/main' into search-refactor 2023-05-03 12:19:06 +02:00