mirror of
https://github.com/meilisearch/meilisearch.git
synced 2024-11-29 16:45:30 +08:00
a616a1d37b
4389: Stabilize scoreDetails r=dureuill a=dureuill # Pull Request ## Related issue Fixes #4359 ## What does this PR do? ### User standpoint - Users no longer need to enable the `scoreDetails` experimental feature to use `showRankingScoreDetails` in search queries. - ⚠️ **Breaking change**: sending an object containing the key `"scoreDetails"` to the `/experimental-features` route is now an error. However, importing a dump of a database where that feature was enabled completes successfully. ### Implementation standpoint - remove `scoreDetails` from the experimental features - remove check on the experimental feature `scoreDetails` before accepting `showRankingScoreDetails` - remove `scoreDetails` from the accepted fields in the `/experimental-features` route - fix tests accordingly ## Manual tests 1. exported a dump with the `scoreDetails` feature enabled on `main` - tried to import the dump after the changes in this PR - the dump imported successfully 2. tried to make a search with `showRankingScoreDetails: true` - the ranking score details are displayed - an automated test case also exists and passes 3. tried to enable the `scoreDetails` in `/experimental-features` - get error message ``` Unknown field `scoreDetails`: expected one of `vectorStore`, `metrics`, `exportPuffinReports` ``` Co-authored-by: Louis Dureuil <louis@meilisearch.com> |
||
|---|---|---|
| .. | ||
| deserr | ||
| compression.rs | ||
| document_formats.rs | ||
| error.rs | ||
| facet_values_sort.rs | ||
| features.rs | ||
| index_uid_pattern.rs | ||
| index_uid.rs | ||
| keys.rs | ||
| lib.rs | ||
| settings.rs | ||
| star_or.rs | ||
| task_view.rs | ||
| tasks.rs | ||
| versioning.rs | ||