bors[bot]
c1ad56281d
Merge #2545 #2556 #2568 #2573 #2574 #2575
...
2545: meilisearch-lib was missing a feature in its cargo.toml r=Kerollmops a=irevoire
Meilisearch-lib was missing a feature to compile on its own
2556: chore: `meilisearch-http` readability improvements r=curquiza a=ryanrussell
## What does this PR do?
Readability improvements in `meilisearch-http`.
Believe these are pretty straightforward; let me know if anything needs adjusted or reverted :)
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
2568: Improve manifest for dependabot r=curquiza a=curquiza
Improve dependabot manifest
- `rebase-strategy: disabled` -> avoid issues with bors we had in the past with the integration team. The automatic rebase of dependabot does not fit with the rebase bors will try to do
- `labels` -> better triage for when I create the release changelogs
2573: Bump docker/login-action from 1 to 2 r=curquiza a=dependabot[bot]
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1 to 2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/login-action/releases ">docker/login-action's releases</a>.</em></p>
<blockquote>
<h2>v2.0.0</h2>
<ul>
<li>Node 16 as default runtime by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/161 ">#161</a>)
<ul>
<li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0 ">Actions Runner</a> version of v2.285.0, which is by default available in GHES 3.4 or later.</li>
</ul>
</li>
<li>chore: update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/170 ">#170</a>)</li>
<li>Bump <code>`@actions/exec</code>` from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/167 ">#167</a>)</li>
<li>Bump <code>`@actions/io</code>` from 1.1.1 to 1.1.2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/168 ">#168</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/176 ">#176</a>)</li>
<li>Bump https-proxy-agent from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/182 ">#182</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/login-action/compare/v1.14.1...v2.0.0 ">https://github.com/docker/login-action/compare/v1.14.1...v2.0.0 </a></p>
<h2>v1.14.1</h2>
<ul>
<li>Revert to Node 12 as default runtime to fix issue for GHE users (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/160 ">#160</a>)</li>
</ul>
<h2>v1.14.0</h2>
<ul>
<li>Update to node 16 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/158 ">#158</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr</code>` from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/157 ">#157</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr-public</code>` from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/156 ">#156</a>)</li>
</ul>
<h2>v1.13.0</h2>
<ul>
<li>Handle proxy settings for aws-sdk (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/152 ">#152</a>)</li>
<li>Workload identity based authentication docs for GCR and GAR (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/112 ">#112</a>)</li>
<li>Test login against ACR (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/49 ">#49</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr</code>` from 3.44.0 to 3.45.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/132 ">#132</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr-public</code>` from 3.43.0 to 3.45.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/131 ">#131</a>)</li>
</ul>
<h2>v1.12.0</h2>
<ul>
<li>ECR: only set credentials if username and password are specified (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/128 ">#128</a>)</li>
<li>Refactor to use aws-sdk v3 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/128 ">#128</a>)</li>
</ul>
<h2>v1.11.0</h2>
<ul>
<li>ECR: switch implementation to use the AWS SDK (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/126 ">#126</a>)</li>
<li><code>ecr</code> input to specify whether the given registry is ECR (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/123 ">#123</a>)</li>
<li>Test against Windows runner (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/126 ">#126</a>)</li>
<li>Update instructions for Google registry (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/127 ">#127</a>)</li>
<li>Update dev workflow (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/111 ">#111</a>)</li>
<li>Small changes for GHCR doc (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/86 ">#86</a>)</li>
<li>Update dev dependencies (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/85 ">#85</a>)</li>
<li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/101 ">#101</a>)</li>
<li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/100 ">#100</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.4.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/94 ">#94</a> <a href="https://github-redirect.dependabot.com/docker/login-action/issues/103 ">#103</a>)</li>
<li>Bump codecov/codecov-action from 1 to 2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/88 ">#88</a>)</li>
<li>Bump hosted-git-info from 2.8.8 to 2.8.9 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/83 ">#83</a>)</li>
<li>Bump node-notifier from 8.0.0 to 8.0.2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/82 ">#82</a>)</li>
<li>Bump ws from 7.3.1 to 7.5.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/81 ">#81</a>)</li>
<li>Bump lodash from 4.17.20 to 4.17.21 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/80 ">#80</a>)</li>
<li>Bump y18n from 4.0.0 to 4.0.3 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/79 ">#79</a>)</li>
</ul>
<h2>v1.10.0</h2>
<ul>
<li>GitHub Packages Docker Registry deprecated (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/78 ">#78</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="49ed152c8ehttps://github-redirect.dependabot.com/docker/login-action/issues/161 ">#161</a> from crazy-max/node16-runtime</li>
<li><a href="b61a9ce7bd3a136a8631https://github-redirect.dependabot.com/docker/login-action/issues/182 ">#182</a> from docker/dependabot/npm_and_yarn/https-proxy-agent...</li>
<li><a href="b312880b69795794e0811edf6180e0https://github-redirect.dependabot.com/docker/login-action/issues/179 ">#179</a> from docker/dependabot/github_actions/codecov/codecov...</li>
<li><a href="8e66ad40897c79b598eahttps://github-redirect.dependabot.com/docker/login-action/issues/176 ">#176</a> from docker/dependabot/npm_and_yarn/minimist-1.2.6</li>
<li><a href="24a38e0d6d70e1ff84cbhttps://github-redirect.dependabot.com/docker/login-action/issues/170 ">#170</a> from crazy-max/eslint</li>
<li>Additional commits viewable in <a href="https://github.com/docker/login-action/compare/v1...v2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2574: Bump Swatinem/rust-cache from 1.3.0 to 1.4.0 r=curquiza a=dependabot[bot]
Bumps [Swatinem/rust-cache](https://github.com/Swatinem/rust-cache ) from 1.3.0 to 1.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/releases ">Swatinem/rust-cache's releases</a>.</em></p>
<blockquote>
<h2>v1.4.0</h2>
<ul>
<li>Clean both debug and release target directories.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/blob/v1/CHANGELOG.md ">Swatinem/rust-cache's changelog</a>.</em></p>
<blockquote>
<h2>1.4.0</h2>
<ul>
<li>Clean both <code>debug</code> and <code>release</code> target directories.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="cb2cf0cc7c74e8e24b6df8f67b75155b2b053862https://github-redirect.dependabot.com/Swatinem/rust-cache/issues/49 ">#49</a>)</li>
<li><a href="3bb3a9a087d127014599801365cd81https://github-redirect.dependabot.com/Swatinem/rust-cache/issues/34 ">#34</a>)</li>
<li><a href="c5ed9ba6b7536c94f32chttps://github-redirect.dependabot.com/Swatinem/rust-cache/issues/22 ">#22</a>)</li>
<li>See full diff in <a href="https://github.com/Swatinem/rust-cache/compare/v1.3.0...v1.4.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2575: Bump docker/build-push-action from 2 to 3 r=curquiza a=dependabot[bot]
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases ">docker/build-push-action's releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<ul>
<li>Node 16 as default runtime by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/564 ">#564</a>)
<ul>
<li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0 ">Actions Runner</a> version of v2.285.0, which is by default available in GHES 3.4 or later.</li>
</ul>
</li>
<li>Standalone mode support by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/601 ">#601</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/609 ">#609</a>)</li>
<li>chore: update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/571 ">#571</a>)</li>
<li>Bump <code>`@actions/exec</code>` from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/573 ">#573</a>)</li>
<li>Bump <code>`@actions/github</code>` from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/582 ">#582</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/584 ">#584</a>)</li>
<li>Bump semver from 7.3.5 to 7.3.7 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/595 ">#595</a>)</li>
<li>Bump csv-parse from 4.16.3 to 5.0.4 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/533 ">#533</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v2.10.0...v3.0.0 ">https://github.com/docker/build-push-action/compare/v2.10.0...v3.0.0 </a></p>
<h2>v2.10.0</h2>
<ul>
<li>Add <code>imageid</code> output and use metadata to set <code>digest</code> output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/569 ">#569</a>)</li>
<li>Add <code>build-contexts</code> input (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/563 ">#563</a>)</li>
<li>Enhance outputs display (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/559 ">#559</a>)</li>
</ul>
<h2>v2.9.0</h2>
<ul>
<li><code>add-hosts</code> input (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/553 ">#553</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/555 ">#555</a>)</li>
<li>Fix git context subdir example and improve README (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/552 ">#552</a>)</li>
<li>Add e2e tests for ACR (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/548 ">#548</a>)</li>
<li>Add description on <code>github-token</code> option to README (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/544 ">#544</a>)</li>
<li>Bump node-fetch from 2.6.1 to 2.6.7 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/549 ">#549</a>)</li>
</ul>
<h2>v2.8.0</h2>
<ul>
<li>Allow specifying subdirectory with default git context (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/531 ">#531</a>)</li>
<li>Add <code>cgroup-parent</code>, <code>shm-size</code>, <code>ulimit</code> inputs (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/501 ">#501</a>)</li>
<li>Don't set outputs if empty or nil (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/470 ">#470</a>)</li>
<li>docs: example to sanitize tags with metadata-action (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/476 ">#476</a>)</li>
<li>docs: wrong syntax to sanitize repo slug (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/475 ">#475</a>)</li>
<li>docs: test before pushing your image (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/455 ">#455</a>)</li>
<li>readme: remove v1 section (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/500 ">#500</a>)</li>
<li>ci: virtual env file system info (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/510 ">#510</a>)</li>
<li>dev: update workflow (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/499 ">#499</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.5.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/160 ">#160</a>)</li>
<li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/469 ">#469</a>)</li>
<li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/465 ">#465</a>)</li>
<li>Bump csv-parse from 4.16.0 to 4.16.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/451 ">#451</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/459 ">#459</a>)</li>
</ul>
<h2>v2.7.0</h2>
<ul>
<li>Add <code>metadata</code> output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/412 ">#412</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.4.0 to 1.5.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/439 ">#439</a>)</li>
<li>Add note to sanitize tags (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/426 ">#426</a>)</li>
<li>Cache backend API docs (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/406 ">#406</a>)</li>
<li>Git context now supports subdir (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/407 ">#407</a>)</li>
<li>Bump codecov/codecov-action from 1 to 2 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/415 ">#415</a>)</li>
</ul>
<h2>v2.6.1</h2>
<ul>
<li>Small typo and ensure trimmed output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/400 ">#400</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e551b19e49https://github-redirect.dependabot.com/docker/build-push-action/issues/564 ">#564</a> from crazy-max/node-16</li>
<li><a href="3554377aa3https://github-redirect.dependabot.com/docker/build-push-action/issues/609 ">#609</a> from crazy-max/ci-fix-test</li>
<li><a href="a62bc1b22bc2085839e1https://github-redirect.dependabot.com/docker/build-push-action/issues/601 ">#601</a> from crazy-max/standalone-mode</li>
<li><a href="fcd91249e5https://github-redirect.dependabot.com/docker/build-push-action/issues/607 ">#607</a> from docker/dependabot/github_actions/docker/metadata...</li>
<li><a href="0ebe720aed38b45804b5ba317382dchttps://github-redirect.dependabot.com/docker/build-push-action/issues/533 ">#533</a> from docker/dependabot/npm_and_yarn/csv-parse-5.0.4</li>
<li><a href="43721d23465ea21bf2bahttps://github.com/docker/build-push-action/compare/v2...v3 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: Ryan Russell <git@ryanrussell.org>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-04 12:13:46 +00:00
Kerollmops
aff8cd1774
Make clippy happy
2022-07-04 13:36:56 +02:00
Ryan Russell
9b660e1058
chore(routes): correct typo
...
Signed-off-by: Ryan Russell <git@ryanrussell.org>
2022-06-28 18:09:22 -05:00
bors[bot]
9e261b996f
Merge #2543
...
2543: fix all the array on the search get route and improve the tests r=curquiza a=irevoire
fix #2527
Co-authored-by: Tamo <tamo@meilisearch.com>
2022-06-23 14:51:36 +00:00
Kerollmops
dad86fc3d6
Make the changes necessary to use milli 0.31.1
2022-06-23 10:47:49 +02:00
Tamo
c47369b502
fix all the array on the search get route and improve the tests
2022-06-22 14:33:44 +02:00
Kerollmops
22e1ac969a
Add specific routes for the pagination and faceting settings
2022-06-15 15:27:06 +02:00
Ryan Russell
8990b12609
docs: Readability fixes in src/analytics/.rs files
...
Signed-off-by: Ryan Russell <git@ryanrussell.org>
2022-06-11 10:21:05 -05:00
pierre-l
b8745420da
Use the IndexUid and StarOr in meilisearch_auth::Key
...
Move `meilisearch_http::routes::StarOr` to `meilisearch_types::star_or`
Fixes #2158
2022-06-09 16:14:15 +02:00
pierre-l
36cb09eb25
Add a new meilisearch_types crate
...
Move `meilisearch_error` to `meilisearch_types::error`
Move `meilisearch_lib::index_resolver::IndexUid` to `meilisearch_types::index_uid`
Add a new `InvalidIndexUid` error in `meilisearch_types::index_uid`
2022-06-09 16:14:13 +02:00
bors[bot]
b9b32d65a8
Merge #2494
...
2494: Introduce the new faceting and pagination settings r=ManyTheFish a=Kerollmops
This PR introduces two new settings following the newly created spec https://github.com/meilisearch/specifications/pull/157 :
- The `faceting.max_values_per_facet` one describes the maximum number of values (each with a count) associated with a value in a facet distribution query.
- The `pagination.limited_to` one describes the maximum number of documents that a search query can ever return.
Co-authored-by: Kerollmops <clement@meilisearch.com>
2022-06-09 12:09:21 +00:00
bors[bot]
2b2e571c76
Merge #2460
...
2460: Create custom error types for `TaskType`, `TaskStatus`, and `IndexUid` r=Kerollmops a=walterbm
# Pull Request
## What does this PR do?
Fixes #2443 by making the following changes:
- Add custom `TaskTypeError` for `TaskType::from_str`
- Add custom `TaskStatusError` for `TaskStatus::from_str`
- Add custom `IndexUidFormatError` for `IndexUid::from_str`
- Implement `From<IndexUidFormatError> for IndexResolverError` to convert between errors
- Replace all usages of `IndexUid::new` with `IndexUid::from_str`
- **NOTE** I am relatively new to Rust and I struggled a lot with this final part. This PR ended up with a messy error conversion which does not seem ideal. Please let me know if you have any suggestions for how to make this better and I'll be happy to make any updates!
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: walter <walter.beller.morales@gmail.com>
2022-06-09 09:10:28 +00:00
Kerollmops
1e3dcbea3f
Plug the pagination.limited_to setting
2022-06-09 10:56:42 +02:00
Kerollmops
b96399d24b
Plug the faceting.max_values_per_facet setting
2022-06-09 10:56:42 +02:00
Kerollmops
5450b5ced3
Add the faceting.max_values_per_facet setting
2022-06-09 10:54:32 +02:00
walter
3e5d6be86b
Rename TaskType::from_str parameter to 'type_'
2022-06-08 19:57:45 -04:00
bors[bot]
09ec8e9fca
Merge #2471
...
2471: Remove the connection keep-alive timeout r=MarinPostma a=Thearas
# Pull Request
## What does this PR do?
Fixes <https://github.com/meilisearch/meilisearch-go/issues/221 >.
Meilisearch has a default connection keep-alive timeout for 5s, which means it will close the connections with idle time >= 5s.
This PR set actix-web keep-alive config to `KeepAlive::Os`, let the client and system to decide when to close the connection.
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Co-authored-by: Thearas <thearas850@gmail.com>
2022-06-08 06:59:25 +00:00
ManyTheFish
6ffa222218
feat(auth): Paginate API keys listing
...
- [x] Update tests
- [x] Use Pagination helpers to paginate API keys
fixes #2442
2022-06-07 17:37:48 +02:00
Thearas
9b9cbc815b
fmt
2022-06-07 03:50:39 +08:00
Thearas
fd11903920
remove the connection timeout
2022-06-07 03:38:23 +08:00
Kerollmops
e5b760c59a
Fix the segment analytics tests
2022-06-06 10:44:46 +02:00
Kerollmops
277a0a7967
Bump serde-cs to simplify our usage of the star_or function
2022-06-06 10:17:33 +02:00
Kerollmops
64b5b2e1f8
Use serde-cs::CS with StarOr to reduce the logic duplication
2022-06-06 10:06:00 +02:00
Kerollmops
10d3b367dc
Simplify the const default values
2022-06-06 10:06:00 +02:00
walter
0e7e16ae72
Add custom TaskStatusError for TaskStatus
2022-06-05 00:51:08 -04:00
walter
80c156df3f
Add custom TaskTypeError for TaskType
2022-06-05 00:51:08 -04:00
bors[bot]
b83455f345
Merge #2454
...
2454: Unify the pagination of the index and documents route behind a common type r=curquiza a=irevoire
`@MarinPostma` wdyt of keeping the `auto_paginate_sized` until we implement the pagination on every route that needs it just to see if it could be useful to something else
Co-authored-by: Tamo <tamo@meilisearch.com>
2022-06-02 15:01:43 +00:00
ad hoc
0c5352fc22
move index_uid from task to task_content
2022-06-02 15:30:35 +02:00
Tamo
12b5eabd5d
chore(http): unify the pagination of the index and documents route behind a common type
2022-06-02 14:06:56 +02:00
bors[bot]
cf2d8de48a
Merge #2452
...
2452: Change http verbs r=ManyTheFish a=Kerollmops
This PR fixes #2419 by updating the HTTP verbs used to update the settings and every single setting parameter.
- [x] `PATCH /indexes/{indexUid}` instead of `PUT`
- [x] `PATCH /indexes/{indexUid}/settings` instead of `POST`
- [x] `PATCH /indexes/{indexUid}/settings/typo-tolerance` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/displayed-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/distinct-attribute` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/filterable-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/ranking-rules` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/searchable-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/sortable-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/stop-words` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/synonyms` instead of `POST`
Co-authored-by: Kerollmops <clement@meilisearch.com>
2022-06-02 11:46:17 +00:00
bors[bot]
c9cd1738a5
Merge #2445
...
2445: Seek-based tasks list r=Kerollmops a=Kerollmops
This PR implements the seek-based pagination for the tasks list following [the spec](https://github.com/meilisearch/specifications/pull/115 ).
Co-authored-by: Kerollmops <clement@meilisearch.com>
2022-06-02 10:25:54 +00:00
Kerollmops
10a71fdb10
Update the /indexes/{indexUid}/settings/* verbs by adding a macro parameter
2022-06-02 11:55:47 +02:00
Kerollmops
f8d3f739ad
Update the /indexes/{indexUid}/settings verb from POST to PATCH
2022-06-02 11:55:47 +02:00
Kerollmops
bb405aa729
Update the /indexes/{indexUid} verb from PUT to PATCH
2022-06-02 11:55:47 +02:00
Kerollmops
dfce9ba468
Apply suggestions
2022-06-02 11:26:12 +02:00
ManyTheFish
4512eed8f5
Fix PR comments
2022-06-01 18:06:20 +02:00
ManyTheFish
b2e2dc8558
Re-authorize master_key to access to all routes
2022-06-01 16:17:47 +02:00
ManyTheFish
b3c8915702
Make small changes and renaming
2022-06-01 16:08:42 +02:00
ManyTheFish
b9a79eb858
Change apiKeyPrefix to apiKeyUid
2022-06-01 16:07:44 +02:00
ManyTheFish
a57b2d9538
Restrict master key access to /keys routes
2022-06-01 16:07:44 +02:00
ManyTheFish
34c8888f56
Add keys actions
2022-06-01 16:07:44 +02:00
ManyTheFish
96a5791e39
Add uid and name fields in keys
2022-06-01 16:07:44 +02:00
Kerollmops
d80e8b64af
Align the tasks route API to the new spec
2022-06-01 15:30:39 +02:00
Kerollmops
c11d21879a
Introduce tasks limit and after to the tasks route
2022-06-01 13:26:36 +02:00
Kerollmops
9d5cc88cd5
Implement the seek-based tasks list pagination
2022-06-01 12:09:52 +02:00
bors[bot]
e81c7aa2e6
Merge #2423
...
2423: Paginate the index resource r=MarinPostma a=irevoire
Fix #2373
Co-authored-by: Irevoire <tamo@meilisearch.com>
2022-05-31 19:25:25 +00:00
bors[bot]
47007fa71b
Merge #2446
...
2446: rename Succeded to Succeeded r=irevoire a=MarinPostma
this pr renames `TaskEvent::Succeded` to `TaskEvent::Succeeded` and apply the migration to the dumps
Co-authored-by: ad hoc <postma.marin@protonmail.com>
2022-05-31 18:27:02 +00:00
Irevoire
627f13df85
feat(http): paginate the index resource
...
Fix #2373
2022-05-31 18:11:45 +02:00
ad hoc
446f1f31e0
rename Succeded to Succeeded
2022-05-31 17:22:37 +02:00
Irevoire
ddad6cc069
feat(http): update the documents resource
...
- Return Documents API resources on `/documents` in an array in the the results field.
- Add limit, offset and total in the response body.
- Rename `attributesToRetrieve` into `fields` (only for the `/documents` endpoints, not for the `/search` ones).
- The `displayedAttributes` settings does not impact anymore the displayed fields returned in the `/documents` endpoints. These settings only impacts the `/search` endpoint.
Fix #2372
2022-05-31 16:40:40 +02:00
Kerollmops
1465b5e0ff
Refactorize the tasks filters by moving the match inside
2022-05-31 11:33:21 +02:00
Kerollmops
8800b348f0
Implement the StarOr on all the tasks filters
2022-05-31 11:33:21 +02:00
Kerollmops
082d6b89ff
Make the StarOrIndexUid Generic and call it StarOr
2022-05-31 11:33:21 +02:00
Kerollmops
b82c86c8f5
Allow users to filter indexUid with a *
2022-05-31 11:33:20 +02:00
Kerollmops
36d94257d8
Make clippy happy
2022-05-31 11:33:20 +02:00
Kerollmops
3f80468f18
Rename the Tasks Types
2022-05-31 11:33:20 +02:00
Kerollmops
8509243e68
Implement the status and type filtering on the tasks route
2022-05-31 11:33:20 +02:00
Kerollmops
3684c822f1
Add indexUid filtering on the /tasks route
2022-05-31 11:33:20 +02:00
Kerollmops
80f7d87356
Remove the /indexes/:indexUid/tasks/... routes
2022-05-31 11:33:20 +02:00
Kerollmops
d2f457a076
Rename the uid to taskUid in asynchronous response
2022-05-31 11:33:20 +02:00
Kerollmops
e5ef5a6f9c
Remove an unused updates.rs file
2022-05-31 11:33:19 +02:00
bors[bot]
3441cc6c36
Merge #2410
...
2410: Make dump a task r=Kerollmops a=MarinPostma
This PR transforms the dump task into a proper task.
The `GET /dumps/:dump_uid` is removed.
Some changes were made to make this work, and a bit a refactoring was necessary.
- The `dump_actor` module has been renamed do `dumps` and moved to the root
- There isn't a `DumpActor` anymore, and the dump process is handled by the `DumpHandler`.
- The `TaskPerformer` is renamed to `BatchHandler`
- The `BatchHandler` trait no longer has a `perform_job` method, but instead has a `accept` method returning whether a handler can proccess a batch
- The scheduler now accept a list of `BatchHandler`, and iterates trhough them until it finds one to accept the current batch.
- `Job` doesn't exist anymore, and everything in now inside of the `BatchContent` enum.
- The `Vec<TaskId>` from `Batch` is replaced with a `BatchContent` enum which hints at the content.
- The Scheduler is slightly modified to accept batch, and prioritize them before regular tasks.
- The `TaskList` are not identified by a `String` representing the index uid anymore, but by a `TaskListIdentifier` which also works for dumps which are not targeting any specific indexes.
- The `GET /dump/:dump_id` no longer exists
- `DumpActorError` is renamed to `DumpError`
close #2410
Co-authored-by: ad hoc <postma.marin@protonmail.com>
2022-05-30 14:09:43 +00:00
Irevoire
d47b997120
chore(analytics): update the url used to send our analytics
2022-05-30 15:13:10 +02:00
ad hoc
61035a3ea4
create dump v5
2022-05-25 11:13:34 +02:00
ad hoc
4778884105
remove dump status route
2022-05-25 11:13:34 +02:00
ad hoc
57fde30b91
handle dump
2022-05-25 11:13:34 +02:00
ad hoc
414d0907ce
register dump handler
2022-05-25 11:13:34 +02:00
ad hoc
60a8249de6
add dump batch handler
2022-05-25 11:13:34 +02:00
ad hoc
46cdc17701
make scheduler accept multiple batch handlers
2022-05-25 11:13:34 +02:00
ad hoc
7fa3eb1003
register dump tasks
2022-05-25 11:13:33 +02:00
ad hoc
5a5066023b
introduce TaskListIdentifier
2022-05-25 11:13:33 +02:00
ad hoc
aa50acb031
make Task index_uid an option
...
Not all task relate to an index. Tasks that don't have an index_uid set
to None
2022-05-25 11:13:32 +02:00
bors[bot]
ca9ba2d90c
Merge #2406
...
2406: chore(search): rename in the search endpoint r=irevoire a=irevoire
Fix #2376
Co-authored-by: Irevoire <tamo@meilisearch.com>
2022-05-24 12:02:45 +00:00
Tamo
6bf4db0bca
feat(analytics): handle the new x-meilisearch-client custom header for the analytics
...
Fix #2367
2022-05-23 13:51:19 +02:00
Irevoire
4e9accdeb7
chore(search): rename in the search endpoint
...
Fix ##2376
2022-05-19 16:31:37 +02:00
ad hoc
b94eabe48c
apply clippy fixes
2022-05-04 11:33:43 +02:00
ad hoc
34f75d9792
settings analytics return null when no set
2022-04-29 16:38:21 +02:00
Guillaume Mourier
3d0a4a3d18
fix(http): fix event name for typo tolerance settings update
2022-04-27 14:49:21 +02:00
ad hoc
3d10af0333
feat(http): add analytics on typo tolerance setting
2022-04-26 18:29:32 +02:00
bors[bot]
b1333ab5b0
Merge #2320
...
2320: chore(http, lib): rename typo to typo_tolerance r=irevoire a=MarinPostma
fix #2319
Co-authored-by: ad hoc <postma.marin@protonmail.com>
2022-04-14 09:50:39 +00:00
ad hoc
276dc6043a
chore(http, lib): rename typo to typo_tolerance
2022-04-14 10:42:06 +02:00
bors[bot]
b9e676b8ca
Merge #2316
...
2316: Add version flag r=Kerollmops a=sanders41
# Pull Request
## What does this PR do?
Fixes #2315
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: Paul Sanders <psanders1@gmail.com>
2022-04-13 17:24:09 +00:00
bors[bot]
6c06fb226d
Merge #2307
...
2307: Feat(Analytics): Add analytics for search format options r=irevoire a=ManyTheFish
Specification: [#120 ](https://github.com/meilisearch/specifications/pull/120 ) ([f5c6a8e](f5c6a8e183fix #2308
Co-authored-by: ManyTheFish <many@meilisearch.com>
2022-04-13 12:01:52 +00:00
Paul Sanders
41249be274
Add version flag
2022-04-12 15:22:36 -04:00
Tamo
2ee210483f
fix(search): remove the back and forth between the IndexMap and the serde_json::Map
...
This is ok because we're using the preserve_order feature in serde_json which is already internally using an IndexMap.
2022-04-12 16:12:52 +02:00
ManyTheFish
0990e95830
Feat(Analytics): Add analytics for search format options
2022-04-11 14:53:15 +02:00
Tamo
69d312209e
feat(search): Implements the nested fields
...
See https://github.com/meilisearch/specifications/pull/121
2022-04-07 19:47:20 +02:00
bors[bot]
013fe4cbc9
Merge #2297
...
2297: Feat(Search): Enhance formating search results r=ManyTheFish a=ManyTheFish
Add new settings and change crop_len behavior to count words instead of characters.
- [x] `highlightPreTag`
- [x] `highlightPostTag`
- [x] `cropMarker`
- [x] `cropLength` count word instead of chars
- [x] `cropLength` 0 is now considered as no `cropLength`
- [ ] ~smart crop finding the best matches interval~ (postponed)
Partially fixes #2214 . (no smart crop)
Co-authored-by: ManyTheFish <many@meilisearch.com>
2022-04-07 13:29:56 +00:00
ManyTheFish
dc2cc1ee89
Feat(Search): Enhance formating search results
2022-04-07 15:04:08 +02:00
ad hoc
981fba5b44
feat(all): introduce disable typos
2022-04-06 15:47:48 +02:00
bors[bot]
7f7958f815
Merge #2277
...
2277: fix(http): fix panic when sending document update without content type header r=MarinPostma a=MarinPostma
I found a panic when pushing documents without a content-type. This fixes is by returning unknown instead of crashing.
Co-authored-by: ad hoc <postma.marin@protonmail.com>
2022-04-05 12:07:17 +00:00
shiori
9edd407a88
Merge branch 'main' into add-instance-options
2022-03-31 02:38:07 +09:00
ad hoc
6c2fdc7743
fix(http): fix panic when sending document update without content type header
2022-03-29 09:48:25 +02:00
bors[bot]
513b37e245
Merge #2253
...
2253: refactor authentication key extraction r=ManyTheFish a=MarinPostma
I am concerned that the part of the code that performs the key prefix extraction from the jwt token migh be misused in the future. Since this is a critical part of the code, I moved it into it's own function. Since we deserialized the payload twice anyway, I reordered the verifications, and we now use the data from the validated token.
Co-authored-by: ad hoc <postma.marin@protonmail.com>
2022-03-28 08:53:13 +00:00
2shiori17
705d10a96d
Add instance options for RAM and CPU usage
2022-03-24 18:52:36 +00:00
Kerollmops
3df542f072
Export milli's heed from meilisearch-lib
2022-03-24 15:30:10 +01:00
Kerollmops
ee6be4f6b9
Import milli from meilisearch-lib in meilisearch-http
2022-03-24 14:45:37 +01:00
ad hoc
6a82a055d3
chore(auth): refactor token validation
2022-03-21 11:18:51 +01:00
bors[bot]
7e65816d63
Merge #2237
...
2237: Update dependencies r=MarinPostma a=Kerollmops
This PR upgrade and updates the dependencies of meilisearch, but first I removed three unused dependencies. I used [cargo udeps](https://github.com/est31/cargo-udeps ) to detect those and [cargo upgrade](https://github.com/killercup/cargo-edit/blob/master/README.md#available-subcommands ) to upgrade ⬆️
~This PR **must** be merged when https://github.com/meilisearch/milli/pull/465 is merged and then must be updated accordingly i.e. using the latest version of milli.~
Co-authored-by: Kerollmops <clement@meilisearch.com>
Co-authored-by: ManyTheFish <many@meilisearch.com>
2022-03-17 17:15:19 +00:00
Kerollmops
5bffa4b7f9
Tenant token validation is now created by a function
2022-03-17 17:55:50 +01:00
bors[bot]
d1c0ecceb9
Merge #2245
...
2245: Add test to validate cli r=irevoire a=MarinPostma
followup on #2242 and #2243
Add a test to make sure the cli is valid, and add a CI task to run the tests in debug to make sure we hit debug assertions.
FYI `@curquiza,` because of CI changes
Co-authored-by: ad hoc <postma.marin@protonmail.com>
2022-03-17 16:14:31 +00:00
ManyTheFish
4aef7c5ac5
Fix tenant token validation when exp is null
2022-03-17 11:05:03 +01:00
Kerollmops
968053649b
Change the jsonwebtoken crate usage
2022-03-17 11:03:32 +01:00
ad hoc
22c61a1ecb
chore(http): add test for validity of cli
2022-03-16 17:17:57 +01:00
Sai Kumar
e271395971
chore(all): bump milli
...
* updates to Use the milli's heed dependency #2210
* Update index.rs
* Update store.rs
* Update mod.rs
* cargo fmt
2022-03-16 16:34:44 +01:00
bors[bot]
b669a73432
Merge #2209
...
2209: rename auto batching cli r=curquiza a=MarinPostma
rename `--enable-autobatching` to `--enable-auto-batching`.
as per https://github.com/meilisearch/specifications/pull/96#issuecomment-1060693721
Co-authored-by: ad hoc <postma.marin@protonmail.com>
2022-03-07 15:58:58 +00:00
ad hoc
62ce8e0bda
chore(http): rename auto batching cli option
2022-03-07 15:19:19 +01:00
ad hoc
ddd25bfe01
remove token from InvalidToken error
2022-03-07 15:16:07 +01:00
ad hoc
19da45c53b
Update meilisearch-http/src/extractors/sequential_extractor.rs
...
Co-authored-by: Clément Renault <clement@meilisearch.com>
2022-03-07 15:02:07 +01:00
ad hoc
b57c59baa4
sequential extractor
2022-03-04 20:43:12 +01:00
ad hoc
af8a5f2c21
async auth
2022-03-02 19:25:51 +01:00
ad hoc
d6400aef27
remove async from meilsearch-authentication
2022-03-02 18:22:34 +01:00
ManyTheFish
c2b58720d1
Fix(dumps): Explicitly define serde for time
2022-03-02 11:37:48 +01:00
Rob Ede
15150db957
clippy
2022-02-28 19:03:38 +01:00
Rob Ede
3b2e467ca6
update actix-web dependency to 4.0
2022-02-28 19:03:37 +01:00
ad hoc
4fbb83a34d
bug(snapshot): Correctly open environments in snapshots
2022-02-28 12:37:30 +01:00
Tamo
6312e7f1f3
fix(analytics): flatten the scheduler options
2022-02-22 15:55:50 +01:00
Irevoire
05c8d81e65
chore: get rid of chrono in favor of time
...
Chrono has been unmaintened for a few month now and there is a CVE on it.
make clippy happy
bump milli
2022-02-16 18:14:29 +01:00
mpostma
c9a236b0af
feat(lib): auto-batching
2022-02-01 18:06:20 +01:00
bors[bot]
622c15e825
Merge #2096
...
2096: feat(auth): Tenant token r=Kerollmops a=ManyTheFish
Make meilisearch support JWT authentication signed with meilisearch API keys
using HS256, HS384 or HS512 algorithms.
Related spec: [specifications#89](https://github.com/meilisearch/specifications/pull/89 ) [rendered](https://github.com/meilisearch/specifications/blob/scoped-api-keys/text/0089-tenant-tokens.md )
Fix #1991
Co-authored-by: ManyTheFish <many@meilisearch.com>
2022-01-27 10:38:41 +00:00
ManyTheFish
7ca647f0d0
feat(auth): Implement Tenant token
...
Make meilisearch support JWT authentication signed with meilisearch API keys
using HS256, HS384 or HS512 algorithms.
Related spec: https://github.com/meilisearch/specifications/pull/89
Fix #1991
2022-01-27 08:25:39 +01:00
Tamo
72d9c5ee5c
fix(rebranding): Update the ascii art ( #2118 )
2022-01-26 18:53:07 +01:00
Clémentine Urquizar
8a959da120
Update MeiliSearch into Meilisearch everywhere
2022-01-26 17:43:16 +01:00
bors[bot]
c8bb54cd94
Merge #2098
...
2098: feat(dump): Provide the same cli options as the snapshots r=MarinPostma a=irevoire
Add two cli options for the dump:
- `--ignore-missing-dump`
- `--ignore-dump-if-db-exists`
Fix #2087
Co-authored-by: Tamo <tamo@meilisearch.com>
2022-01-26 14:32:23 +00:00
Tamo
bad4bed439
feat(dump): Provide the same cli options as the snapshots
...
Add two cli options for the dump:
- `--ignore-missing-dump`
- `--ignore-dump-if-db-exists`
Fix #2087
2022-01-26 14:34:06 +01:00
Tamo
7828da15c3
feat(analytics): send the whole set of cli options instead of only the snapshot
2022-01-26 13:52:41 +01:00
bors[bot]
7e2f6063ae
Merge #2099 #2108
...
2099: feat(analytics): Set the timestamp of the aggregated event as the first aggregate r=MarinPostma a=irevoire
2108: meta(auth): Enhance tests on authorization r=MarinPostma a=ManyTheFish
Enhance auth tests in order to be able to add new actions without changing tests.
Helping #2080
Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: ManyTheFish <many@meilisearch.com>
2022-01-24 15:13:01 +00:00
Rob Ede
9f5fee404b
chore(all): update actix-web dependency to 4.0.0-beta.21
2022-01-21 20:44:17 +00:00
Tamo
40bf98711c
feat(analytics): Set the timestamp of the aggregated event as the first aggregate
2022-01-20 19:08:57 +01:00
bors[bot]
f9f075bca2
Merge #2068
...
2068: chore(http): migrate from structopt to clap3 r=Kerollmops a=MarinPostma
migrate from structopt to clap3
This fix the long lasting issue with flags require a value, such as `--no-analytics` or `--schedule-snapshot`.
All flag arguments now take NO argument, i.e:
`meilisearch --schedule-snapshot true` becomes `meilisearch --schedule-snapshot`
as per https://docs.rs/clap/latest/clap/struct.Arg.html#method.env , the env variable is defines as:
> A false literal is n, no, f, false, off or 0. An absent environment variable will also be considered as false. Anything else will considered as true.
`@gmourier`
`@curquiza`
`@meilisearch/docs-team`
Co-authored-by: mpostma <postma.marin@protonmail.com>
2022-01-20 10:59:44 +00:00
mpostma
0c1a3d59eb
fix no-analytics
2022-01-20 11:50:24 +01:00
bors[bot]
010dcc3e80
Merge #2066
...
2066: bug(http): fix task duration r=MarinPostma a=MarinPostma
`@gmourier` found that the duration in the task view was not computed correctly, this pr fixes it.
`@curquiza,` I let you decide if we need to make a hotfix out of this or wait for the next release. This is not breaking.
Co-authored-by: mpostma <postma.marin@protonmail.com>
2022-01-12 14:50:58 +00:00
mpostma
f6d53e03f1
chore(http): migrate from structopt to clap3
2022-01-12 14:07:19 +01:00
mpostma
db83e39a7f
bug(http): fix task duration
2022-01-11 18:01:25 +01:00
Marin Postma
f558ff826a
feat(http): task view indexed and deleted documents return 0 instead of null
2022-01-06 14:55:02 +01:00
Clémentine Urquizar
595250c93e
Allow any header for CORS
2022-01-05 15:38:47 +01:00
ManyTheFish
c0d4f71a34
Bug(auth): Wrap key list in results
2022-01-04 14:10:30 +01:00
ManyTheFish
450b81ca13
Bug(CORS): Add missing allowed headers
...
fix #2040
2022-01-03 13:41:12 +01:00
Clémentine Urquizar
f529c46598
Fix typo in error messages and comments
2021-12-21 16:01:38 +01:00
Maxime Legendre
a845cd8880
Fix(auth): Forbid index creation on alternates routes
...
Forbid index creation on alternates routes when the action `index.create` is not given
fix #2024
2021-12-20 14:48:18 +01:00
Marin Postma
80ed9654e1
chore(http): rename task types
2021-12-15 17:01:34 +01:00
bors[bot]
5af51c852c
Merge #1989
...
1989: Extend API keys r=curquiza a=ManyTheFish
# Pull Request
## What does this PR do?
- Add API keys in snapshots
- Add API keys in dumps
- fix QA #1979
fix #1979
fix #1995
fix #2001
fix #2003
related to #1890
Co-authored-by: many <maxime@meilisearch.com>
2021-12-14 17:22:58 +00:00
many
ee7970f603
feat(auth): Extend API keys
...
- Add API keys in snapshots
- Add API keys in dumps
- Rename action indexes.add to indexes.create
- fix QA #1979
fix #1979
fix #1995
fix #2001
fix #2003
related to #1890
2021-12-14 17:33:39 +01:00
Clément Renault
8c9e51e94f
Make sure that we can also specify the no-analytics flags with a boolean
2021-12-08 11:23:21 +01:00
many
ffefd0caf2
feat(auth): API keys
...
implements:
https://github.com/meilisearch/specifications/blob/develop/text/0085-api-keys.md
- Add tests on API keys management route (meilisearch-http/tests/auth/api_keys.rs)
- Add tests checking authorizations on each meilisearch routes (meilisearch-http/tests/auth/authorization.rs)
- Implement API keys management routes (meilisearch-http/src/routes/api_key.rs)
- Create module to manage API keys and authorizations (meilisearch-auth)
- Reimplement GuardedData to extend authorizations (meilisearch-http/src/extractors/authentication/mod.rs)
- Change X-MEILI-API-KEY by Authorization Bearer (meilisearch-http/src/extractors/authentication/mod.rs)
- Change meilisearch routes to fit to the new authorization feature (meilisearch-http/src/routes/)
- close #1867
2021-12-06 09:52:41 +01:00
Marin Postma
a30e02c18c
feat(all): Task store
...
implements:
https://github.com/meilisearch/specifications/blob/develop/text/0060-refashion-updates-apis.md
linked PR:
- #1889
- #1891
- #1892
- #1902
- #1906
- #1911
- #1914
- #1915
- #1916
- #1918
- #1924
- #1925
- #1926
- #1930
- #1936
- #1937
- #1942
- #1944
- #1945
- #1946
- #1947
- #1950
- #1951
- #1957
- #1959
- #1960
- #1961
- #1962
- #1964
- https://github.com/meilisearch/milli/pull/414
- https://github.com/meilisearch/milli/pull/409
- https://github.com/meilisearch/milli/pull/406
- https://github.com/meilisearch/milli/pull/418
- close #1687
- close #1786
- close #1940
- close #1948
- close #1949
- close #1932
- close #1956
2021-12-02 20:14:42 +01:00
bors[bot]
8363200fd7
Merge #1910
...
1910: After v0.24.0: import `stable` in `main` r=MarinPostma a=curquiza
Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: many <maxime@meilisearch.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Irevoire <tamo@meilisearch.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
2021-11-17 12:48:56 +00:00
Clémentine Urquizar
a1227648ba
Remove email address from the message at the launch
2021-11-11 14:36:45 +01:00
Guillaume Mourier
7c5aad4073
fix aggregated search event names
2021-11-11 01:38:10 +01:00
Irevoire
cc5e884b34
fix the 99th percentile in the analytics
2021-11-10 18:26:38 +01:00
many
6bbc1b4316
Remove error flattening in task serialization
2021-11-04 17:40:28 +01:00
bors[bot]
d9d6dee550
Merge #1873
...
1873: Change lacking errors r=ManyTheFish a=ManyTheFish
Co-authored-by: many <maxime@meilisearch.com>
2021-11-04 14:21:52 +00:00
bors[bot]
3f4e0ec971
Merge #1875 #1876
...
1875: Fix search post event and disk size analytics r=irevoire a=gmourier
- Branch POST search on the post_search aggregator
- Use largest disk `total_space` instead of `available_space`
1876: Update SEGMENT_API_KEY r=irevoire a=gmourier
Branch it on our Segment production stack
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
2021-11-04 10:16:13 +00:00
Guillaume Mourier
6d6725b3b8
Update SEGMENT_API_KEY
2021-11-04 08:10:12 +01:00
Guillaume Mourier
6660be2cb7
Branch POST /search on the dedicated analytics aggregator
2021-11-04 08:03:48 +01:00
Guillaume Mourier
847fcb570b
Use total_space of the largest disk instead of available_space
2021-11-04 08:03:11 +01:00
many
30a094cbb2
Change lacking errors
2021-11-03 14:33:33 +01:00
Tamo
904bae98f8
send the analytics even when the search fail
2021-11-02 12:38:01 +01:00
Tamo
bd49d1c4b5
fix one small bug
2021-10-29 17:25:56 +02:00
marin postma
2665c0099d
clippy + fmt
2021-10-29 17:25:56 +02:00
marin postma
d65f055030
pass anaytics into Arc instead of static ref
2021-10-29 17:25:55 +02:00
Tamo
66d87761b7
align the parameters in the launche resume
2021-10-29 17:25:55 +02:00
Tamo
ba69ad672a
fix the timing issue
2021-10-29 17:25:55 +02:00
Tamo
7934e3956b
replace all mutexes by channel
2021-10-29 17:25:55 +02:00
Guillaume Mourier
68fe93b7db
add ranking_rules marker before sort_position
2021-10-29 17:25:55 +02:00
Tamo
efd0ea9e1e
makes clippy happier
2021-10-29 17:25:55 +02:00
Tamo
6ef73eb226
fix all the single settings route and add the searchable attributes Updated event
2021-10-29 17:25:55 +02:00
Tamo
fc2f23d36c
move the start_since_days to teh root of the identify
2021-10-29 17:25:54 +02:00
Tamo
7c39fab453
move the user-agent out of the context in every request
2021-10-29 17:25:54 +02:00
Tamo
c5164c01c0
set the total of sortable attributes and filterable-attributes to 0 when not set
2021-10-29 17:25:54 +02:00
Tamo
351ad32d77
fix the index_creation boolean
2021-10-29 17:25:54 +02:00
Tamo
3ad8311bdd
split the analytics in a module
2021-10-29 17:25:54 +02:00
Tamo
ea5ae2bae5
sort the imports
2021-10-29 17:25:54 +02:00
Tamo
72e3adc55e
display an instance-id instead of a user-id
2021-10-29 17:25:54 +02:00
Tamo
b250392e8d
remove the first - in the path to the db instance in the instance-id
2021-10-29 17:25:53 +02:00
Tamo
d8b0d68840
use a regex to count the number of filters instead of split + flatten
2021-10-29 17:25:53 +02:00
Tamo
a1ab02f9fb
remove some commented code
2021-10-29 17:25:53 +02:00
Tamo
bba64b32ca
async_traits is not needed anymore
2021-10-29 17:25:53 +02:00
Tamo
9abd2aa9d7
make the analytics interval a const
2021-10-29 17:25:53 +02:00
Tamo
ed750e8792
fix start_since_day
2021-10-29 17:25:53 +02:00
Tamo
37ca50832c
fix the sort position
2021-10-29 17:25:52 +02:00
Tamo
31c7a0105b
fix a bug on the batch documents function
2021-10-29 17:25:52 +02:00
Tamo
ddab9eafa1
fix a typo
2021-10-29 17:25:52 +02:00
Tamo
76a4f86e0c
rename user-id to instance-uid
2021-10-29 17:25:52 +02:00
Tamo
6b34318274
makes clippy happy
2021-10-29 17:25:52 +02:00
Tamo
5508c6c154
a bit of styling
2021-10-29 17:25:52 +02:00
Tamo
9a62ac0c94
send the analytics only once every hours
2021-10-29 17:25:52 +02:00
Tamo
01737ef847
remove all the debug prints
2021-10-29 17:25:51 +02:00
Tamo
10de92987a
compile write_user_id only when the analytics are enabled
2021-10-29 17:25:51 +02:00
Tamo
87a8bf5e96
write and load the user-id in the dumps
2021-10-29 17:25:51 +02:00
Tamo
ba14ea1243
plug the new batchers into the documents route
2021-10-29 17:25:51 +02:00
Tamo
9be90011c6
save the user-id in the config dir of the OS
2021-10-29 17:25:51 +02:00
Tamo
f9b14ca149
simplify the search batcher
2021-10-29 17:25:50 +02:00
Tamo
6591acfdfa
rename the documents batchers
2021-10-29 17:25:50 +02:00
Tamo
e64ba122e1
factorize the code between the two documents batcher
2021-10-29 17:25:50 +02:00
Tamo
a9523146a3
simplify the into_events methods
2021-10-29 17:25:50 +02:00
Tamo
392ee86714
implement the documents batcher
2021-10-29 17:25:50 +02:00
Tamo
1d73f484f0
update the primary key when creating a new index
2021-10-29 17:25:50 +02:00
Tamo
cfcd3ae048
move the version to context.app
2021-10-29 17:25:50 +02:00
Tamo
5395041dcb
fix the stats and stop sending events when no request happened
2021-10-29 17:25:49 +02:00
