From febc93b5466b7af0614df24701bd4f964140776b Mon Sep 17 00:00:00 2001
From: Kerollmops <clement@meilisearch.com>
Date: Tue, 28 Jan 2025 14:41:36 +0100
Subject: [PATCH] wip

---
 crates/fuzzers/src/bin/fuzz-indexing.rs |  2 +-
 crates/milli/src/index.rs               | 15 ++++++++++-----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/crates/fuzzers/src/bin/fuzz-indexing.rs b/crates/fuzzers/src/bin/fuzz-indexing.rs
index ef4e4f8b0..e26303010 100644
--- a/crates/fuzzers/src/bin/fuzz-indexing.rs
+++ b/crates/fuzzers/src/bin/fuzz-indexing.rs
@@ -12,7 +12,7 @@ use milli::documents::mmap_from_objects;
 use milli::heed::EnvOpenOptions;
 use milli::progress::Progress;
 use milli::update::new::indexer;
-use milli::update::{IndexDocumentsMethod, IndexerConfig};
+use milli::update::IndexerConfig;
 use milli::vector::EmbeddingConfigs;
 use milli::Index;
 use serde_json::Value;
diff --git a/crates/milli/src/index.rs b/crates/milli/src/index.rs
index 944fb6cd4..d5a918c2f 100644
--- a/crates/milli/src/index.rs
+++ b/crates/milli/src/index.rs
@@ -1839,9 +1839,15 @@ pub(crate) mod tests {
 
             let embedders =
                 InnerIndexSettings::from_index(&self.inner, &rtxn, None)?.embedding_configs;
-            let mut indexer =
-                indexer::DocumentOperation::new(self.index_documents_config.update_method);
-            indexer.add_documents(&documents).unwrap();
+            let mut indexer = indexer::DocumentOperation::new();
+            match self.index_documents_config.update_method {
+                IndexDocumentsMethod::ReplaceDocuments => {
+                    indexer.replace_documents(&documents).unwrap()
+                }
+                IndexDocumentsMethod::UpdateDocuments => {
+                    indexer.update_documents(&documents).unwrap()
+                }
+            }
 
             let indexer_alloc = Bump::new();
             let (document_changes, operation_stats, primary_key) = indexer.into_changes(
@@ -1928,8 +1934,7 @@ pub(crate) mod tests {
             let embedders =
                 InnerIndexSettings::from_index(&self.inner, &rtxn, None)?.embedding_configs;
 
-            let mut indexer =
-                indexer::DocumentOperation::new(self.index_documents_config.update_method);
+            let mut indexer = indexer::DocumentOperation::new();
             let external_document_ids: Vec<_> =
                 external_document_ids.iter().map(AsRef::as_ref).collect();
             indexer.delete_documents(external_document_ids.as_slice());