snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-25 19:45:05 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix the del items thing

Browse Source
This commit is contained in:
Tamo 2024-09-24 10:52:05 +02:00
parent f2d187ba3e
commit fd8447c521
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
milli/src/update/index_documents/typed_chunk.rs
View File

@ -680,7 +680,7 @@ pub(crate) fn write_typed_chunk_into_index(
let mut iter = merger.into_stream_merger_iter()?; let mut iter = merger.into_stream_merger_iter()?;
while let Some((key, _)) = iter.next()? { while let Some((key, _)) = iter.next()? {
let docid = key.try_into().map(DocumentId::from_be_bytes).unwrap(); let docid = key.try_into().map(DocumentId::from_be_bytes).unwrap();
writer.del_item_raw(wtxn, expected_dimension, docid)?; writer.del_items(wtxn, expected_dimension, docid)?;
} }
// add generated embeddings // add generated embeddings

17
milli/src/vector/mod.rs
View File

@ -170,29 +170,28 @@ impl ArroyWrapper {
Ok(()) Ok(())
} }
/// Delete an item from the index. It **does not** take care of fixing the hole /// Delete all embeddings from a specific `item_id`
/// made after deleting the item. pub fn del_items(
pub fn del_item_raw(
&self, &self,
wtxn: &mut RwTxn, wtxn: &mut RwTxn,
dimension: usize, dimension: usize,
item_id: arroy::ItemId, item_id: arroy::ItemId,
) -> Result<bool, arroy::Error> { ) -> Result<(), arroy::Error> {
for index in arroy_db_range_for_embedder(self.embedder_index) { for index in arroy_db_range_for_embedder(self.embedder_index) {
if self.quantized { if self.quantized {
let writer = arroy::Writer::new(self.quantized_db(), index, dimension); let writer = arroy::Writer::new(self.quantized_db(), index, dimension);
if writer.del_item(wtxn, item_id)? { if !writer.del_item(wtxn, item_id)? {
return Ok(true); break;
} }
} else { } else {
let writer = arroy::Writer::new(self.angular_db(), index, dimension); let writer = arroy::Writer::new(self.angular_db(), index, dimension);
if writer.del_item(wtxn, item_id)? { if !writer.del_item(wtxn, item_id)? {
return Ok(true); break;
} }
} }
} }
Ok(false) Ok(())
} }
/// Delete one item. /// Delete one item.