snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-26 12:05:05 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Improve the error message explaining you can't un-bq an embedder

Browse Source
This commit is contained in:
Tamo 2024-09-19 15:51:29 +02:00
parent 2564ec1496
commit fd43c6c404
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
meilisearch/tests/vector/binary_quantized.rs
View File

@ -317,7 +317,7 @@ async fn try_to_disable_binary_quantization() {
} }
}, },
"error": { "error": {
"message": "`.embedders.manual.binaryQuantized`: Cannot disable the binary quantization", "message": "`.embedders.manual.binaryQuantized`: Cannot disable the binary quantization.\n - Note: Binary quantization is a lossy operation that cannot be reverted.\n - Hint: Add a new embedder that is non-quantized and regenerate the vectors.",
"code": "invalid_settings_embedders", "code": "invalid_settings_embedders",
"type": "invalid_request", "type": "invalid_request",
"link": "https://docs.meilisearch.com/errors#invalid_settings_embedders" "link": "https://docs.meilisearch.com/errors#invalid_settings_embedders"

2
milli/src/error.rs
View File

@ -259,7 +259,7 @@ only composed of alphanumeric characters (a-z A-Z 0-9), hyphens (-) and undersco
#[error("`.embedders.{embedder_name}.dimensions`: `dimensions` cannot be zero")] #[error("`.embedders.{embedder_name}.dimensions`: `dimensions` cannot be zero")]
InvalidSettingsDimensions { embedder_name: String }, InvalidSettingsDimensions { embedder_name: String },
#[error( #[error(
"`.embedders.{embedder_name}.binaryQuantized`: Cannot disable the binary quantization" "`.embedders.{embedder_name}.binaryQuantized`: Cannot disable the binary quantization.\n - Note: Binary quantization is a lossy operation that cannot be reverted.\n - Hint: Add a new embedder that is non-quantized and regenerate the vectors."
)] )]
InvalidDisableBinaryQuantization { embedder_name: String }, InvalidDisableBinaryQuantization { embedder_name: String },
#[error("`.embedders.{embedder_name}.documentTemplateMaxBytes`: `documentTemplateMaxBytes` cannot be zero")] #[error("`.embedders.{embedder_name}.documentTemplateMaxBytes`: `documentTemplateMaxBytes` cannot be zero")]