From faceb661e301c4dbc0590c3b5c26e3c9870f90f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Lecrenier?= Date: Tue, 4 Apr 2023 15:02:01 +0200 Subject: [PATCH] Add note that a part of the code needs fixing --- milli/src/search/new/query_graph.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/milli/src/search/new/query_graph.rs b/milli/src/search/new/query_graph.rs index cba9e590f..1eede33c2 100644 --- a/milli/src/search/new/query_graph.rs +++ b/milli/src/search/new/query_graph.rs @@ -431,6 +431,9 @@ impl QueryGraph { let (start_term, dest_term) = node; let end_term = Interned::from_raw(dest_term.into_raw()); let src = if let Some(start_term) = start_term { + // TODO: this is incorrect! should take the intersection + // between the prev node and the start term if they refer to the same + // original query term! let start_term = Interned::from_raw(start_term.into_raw()); nodes.get_mut(prev_node).successors.insert(start_term); nodes.get_mut(start_term).predecessors.insert(prev_node);