Merge #1113

1113: [ci] Add all target to  check r=MarinPostma a=woshilapin

Follow-up on https://github.com/meilisearch/MeiliSearch/pull/1100#issuecomment-735828974. If you disagree to add this, I'm totally fine to close this PR without merging (related to #1099).

Co-authored-by: Jean SIMARD <woshilapin@tuziwo.info>

.github/workflows/test.yml

@@ -34,6 +34,7 @@ jobs:
       uses: actions-rs/cargo@v1
       with:
         command: clippy
+        args: --all-targets -- --deny warnings
 
   build-image:
     name: Test the build of Docker image

meilisearch-core/examples/from_file.rs

@@ -326,8 +326,11 @@ fn search_command(command: SearchCommand, database: Database) -> Result<(), Box<
 
     let schema = schema.ok_or(meilisearch_core::Error::SchemaMissing)?;
 
-    let fields = command.displayed_fields.iter().map(String::as_str);
-    let fields = HashSet::from_iter(fields);
+    let fields = command
+        .displayed_fields
+        .iter()
+        .map(String::as_str)
+        .collect::<HashSet<_>>();
 
     let config = Config::builder().auto_add_history(true).build();
     let mut readline = Editor::<()>::with_config(config);

meilisearch-core/src/query_tree.rs

@@ -176,7 +176,7 @@ where I: IntoIterator<Item=Operation>,
 
 const MAX_NGRAM: usize = 3;
 
-fn split_query_string<'a, A: AsRef<[u8]>>(s: &str, stop_words: &'a fst::Set<A>) -> Vec<(usize, String)> {
+fn split_query_string<A: AsRef<[u8]>>(s: &str, stop_words: &fst::Set<A>) -> Vec<(usize, String)> {
     // TODO: Use global instance instead
     Analyzer::new(AnalyzerConfig::default_with_stopwords(stop_words))
         .analyze(s)

meilisearch-http/src/helpers/authentication.rs

@@ -101,7 +101,7 @@ where
         } else {
             let error = ResponseError::from(Error::InvalidToken(auth_header.to_string())).error_response();
             let (request, _) = req.into_parts();
-            return Box::pin(ok(ServiceResponse::new(request, error)))
+            Box::pin(ok(ServiceResponse::new(request, error)))
         }
     }
 }

meilisearch-http/src/routes/document.rs

@@ -175,7 +175,7 @@ async fn update_multiple_documents(
             .ok_or(meilisearch_core::Error::SchemaMissing)?;
 
         match (params.into_inner().primary_key, schema.primary_key()) {
-            (Some(_), Some(_)) => return Err(meilisearch_schema::Error::PrimaryKeyAlreadyPresent)?,
+            (Some(_), Some(_)) => return Err(meilisearch_schema::Error::PrimaryKeyAlreadyPresent.into()),
             (Some(key), None) => document_addition.set_primary_key(key),
             (None, None) => {
                 let key = body

meilisearch-http/tests/dump.rs

@@ -16,7 +16,7 @@ async fn trigger_and_wait_dump(server: &mut common::Server) -> String {
 
     let dump_uid = value["uid"].as_str().unwrap().to_string();
 
-    for _ in 0..20 as u8 {
+    for _ in 0..20_u8 {
         let (value, status_code) = server.get_dump_status(&dump_uid).await;
     
         assert_eq!(status_code, 200);