snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-26 12:05:05 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Only reindex if the size increased

Browse Source
This commit is contained in:
Louis Dureuil 2024-09-02 13:52:18 +02:00
parent 66bda2ce8a
commit ed19b7c3c3
No known key found for this signature in database
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
milli/src/vector/settings.rs
View File

@ -196,11 +196,22 @@ impl SettingsDiff {
ReindexAction::RegeneratePrompts, ReindexAction::RegeneratePrompts,
); );
} }
if document_template_max_bytes.apply(new_document_template_max_bytes) { if document_template_max_bytes.apply(new_document_template_max_bytes) {
ReindexAction::push_action( let previous_document_template_max_bytes =
&mut reindex_action, document_template_max_bytes.set().unwrap_or(default_max_bytes().get());
ReindexAction::RegeneratePrompts, let new_document_template_max_bytes =
) new_document_template_max_bytes.set().unwrap_or(default_max_bytes().get());
// only reindex if the size increased. Reasoning:
// - size decrease is a performance optimization, so we don't reindex and we keep the more accurate vectors
// - size increase is an accuracy optimization, so we want to reindex
if new_document_template_max_bytes > previous_document_template_max_bytes {
ReindexAction::push_action(
&mut reindex_action,
ReindexAction::RegeneratePrompts,
)
}
} }
distribution.apply(new_distribution); distribution.apply(new_distribution);