From e06f3808c08ea62246055a58a0d7692b62608a98 Mon Sep 17 00:00:00 2001 From: marin Date: Tue, 15 Dec 2020 17:42:40 +0100 Subject: [PATCH] requested changes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Clément Renault Update meilisearch-http/src/routes/setting.rs Co-authored-by: Clément Renault Update meilisearch-schema/src/schema.rs Update meilisearch-schema/src/schema.rs --- meilisearch-http/src/routes/setting.rs | 2 +- meilisearch-http/tests/dump.rs | 2 -- meilisearch-schema/src/schema.rs | 3 --- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/meilisearch-http/src/routes/setting.rs b/meilisearch-http/src/routes/setting.rs index 773459b8c..f7fae0a6c 100644 --- a/meilisearch-http/src/routes/setting.rs +++ b/meilisearch-http/src/routes/setting.rs @@ -524,7 +524,7 @@ async fn delete_attributes_for_faceting( fn get_indexed_attributes(schema: &Schema) -> Vec { if schema.is_searchable_all() { - ["*"].iter().map(|s| s.to_string()).collect() + vec!["*".to_string()] } else { schema .searchable_names() diff --git a/meilisearch-http/tests/dump.rs b/meilisearch-http/tests/dump.rs index 5ab5db0db..9972a6e17 100644 --- a/meilisearch-http/tests/dump.rs +++ b/meilisearch-http/tests/dump.rs @@ -132,8 +132,6 @@ async fn get_dump_status_should_return_done() { let (value, status_code) = server.trigger_dump().await; - println!("value: {:#?}", value); - assert_eq!(status_code, 202); let dump_uid = value["uid"].as_str().unwrap().to_string(); diff --git a/meilisearch-schema/src/schema.rs b/meilisearch-schema/src/schema.rs index 6e42824f2..17377cedd 100644 --- a/meilisearch-schema/src/schema.rs +++ b/meilisearch-schema/src/schema.rs @@ -239,9 +239,6 @@ mod test { assert_eq!(position, 0.into()); } - #[test] - fn test_insert_with_position_non_all_searchable_attributes() {} - #[test] fn test_insert() { let mut schema = Schema::default();