snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-25 19:45:05 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Remove unimplemented from document changes

Browse Source
This commit is contained in:
ManyTheFish 2024-09-03 15:14:16 +02:00
parent fe69385bd7
commit da61408e52
2 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
milli/src/update/new/document_change.rs
View File

@ -2,7 +2,7 @@ use heed::RoTxn;
use obkv::KvReader; use obkv::KvReader;
use crate::update::new::KvReaderFieldId; use crate::update::new::KvReaderFieldId;
use crate::{DocumentId, FieldId, Index}; use crate::{DocumentId, FieldId, Index, Result};
pub enum DocumentChange { pub enum DocumentChange {
Deletion(Deletion), Deletion(Deletion),
@ -52,8 +52,12 @@ impl Deletion {
self.docid self.docid
} }
pub fn current(&self, rtxn: &RoTxn, index: &Index) -> &KvReader<FieldId> { pub fn current<'a>(
unimplemented!() &self,
rtxn: &'a RoTxn,
index: &'a Index,
) -> Result<Option<&'a KvReader<FieldId>>> {
index.documents.get(rtxn, &self.docid).map_err(crate::Error::from)
} }
} }
@ -67,7 +71,7 @@ impl Insertion {
} }
pub fn new(&self) -> &KvReader<FieldId> { pub fn new(&self) -> &KvReader<FieldId> {
unimplemented!() self.new.as_ref()
} }
} }
@ -85,11 +89,15 @@ impl Update {
self.docid self.docid
} }
pub fn current(&self, rtxn: &RoTxn, index: &Index) -> &KvReader<FieldId> { pub fn current<'a>(
unimplemented!() &self,
rtxn: &'a RoTxn,
index: &'a Index,
) -> Result<Option<&'a KvReader<FieldId>>> {
index.documents.get(rtxn, &self.docid).map_err(crate::Error::from)
} }
pub fn new(&self) -> &KvReader<FieldId> { pub fn new(&self) -> &KvReader<FieldId> {
unimplemented!() self.new.as_ref()
} }
} }

4
milli/src/update/new/extract/extract_word_docids.rs
View File

@ -115,7 +115,7 @@ impl SearchableExtractor for WordDocidsExtractor {
cached_sorter.insert_del_u32(word.as_bytes(), inner.docid()).unwrap(); cached_sorter.insert_del_u32(word.as_bytes(), inner.docid()).unwrap();
}; };
document_tokenizer.tokenize_document( document_tokenizer.tokenize_document(
inner.current(rtxn, index), inner.current(rtxn, index)?.unwrap(),
fields_ids_map, fields_ids_map,
&mut token_fn, &mut token_fn,
)?; )?;
@ -125,7 +125,7 @@ impl SearchableExtractor for WordDocidsExtractor {
cached_sorter.insert_del_u32(word.as_bytes(), inner.docid()).unwrap(); cached_sorter.insert_del_u32(word.as_bytes(), inner.docid()).unwrap();
}; };
document_tokenizer.tokenize_document( document_tokenizer.tokenize_document(
inner.current(rtxn, index), inner.current(rtxn, index)?.unwrap(),
fields_ids_map, fields_ids_map,
&mut token_fn, &mut token_fn,
)?; )?;