snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-26 20:15:07 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Simplify and speedup an intersection pass

Browse Source
This commit is contained in:
Clément Renault 2024-07-10 10:11:44 +02:00
parent 1693d1a311
commit ce61cb7fe6
No known key found for this signature in database
GPG Key ID: F250A4C4E3AE5F5F
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
milli/src/search/new/exact_attribute.rs
View File

@ -193,7 +193,7 @@ impl State {
let mut candidates_per_attribute = Vec::with_capacity(searchable_fields_ids.len()); let mut candidates_per_attribute = Vec::with_capacity(searchable_fields_ids.len());
// then check that there exists at least one attribute that has all of the terms // then check that there exists at least one attribute that has all of the terms
for fid in searchable_fields_ids { for fid in searchable_fields_ids {
let mut intersection = MultiOps::intersection( let intersection = MultiOps::intersection(
words_positions words_positions
.iter() .iter()
.flat_map(|(words, ..)| words.iter()) .flat_map(|(words, ..)| words.iter())
@ -201,12 +201,10 @@ impl State {
.flatten() .flatten()
.map(|word| -> Result<_> { .map(|word| -> Result<_> {
Ok(ctx Ok(ctx
.get_db_word_fid_docids(Some(universe), *word, fid)? .get_db_word_fid_docids(Some(&candidates), *word, fid)?
.unwrap_or_default()) .unwrap_or_default())
}), }),
)?; )?;
// TODO Why not doing this intersection in the MultiOps above?
intersection &= &candidates;
if !intersection.is_empty() { if !intersection.is_empty() {
// Although not really worth it in terms of performance, // Although not really worth it in terms of performance,
// if would be good to put this in cache for the sake of consistency // if would be good to put this in cache for the sake of consistency