snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-30 09:04:59 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Don't recompute filterable fields in evaluation of IN[] filter

Browse Source
This commit is contained in:
Loïc Lecrenier 2022-08-18 10:59:21 +02:00
parent 98f0da6b38
commit c51dcad51b
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
milli/src/search/facet/filter.rs
View File

@ -361,10 +361,7 @@ impl<'a> Filter<'a> {
return Ok(all_ids - selected); return Ok(all_ids - selected);
} }
FilterCondition::In { fid, els } => { FilterCondition::In { fid, els } => {
// TODO: this could be optimised if crate::is_faceted(fid.value(), filterable_fields) {
let filterable_fields = index.filterable_fields(rtxn)?;
if crate::is_faceted(fid.value(), &filterable_fields) {
let field_ids_map = index.fields_ids_map(rtxn)?; let field_ids_map = index.fields_ids_map(rtxn)?;
if let Some(fid) = field_ids_map.id(fid.value()) { if let Some(fid) = field_ids_map.id(fid.value()) {
@ -382,7 +379,7 @@ impl<'a> Filter<'a> {
} else { } else {
return Err(fid.as_external_error(FilterError::AttributeNotFilterable { return Err(fid.as_external_error(FilterError::AttributeNotFilterable {
attribute: fid.value(), attribute: fid.value(),
filterable_fields, filterable_fields: filterable_fields.clone(),
}))?; }))?;
} }
} }