snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-22 18:17:39 +08:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

List TODOs

Browse Source
This commit is contained in:
ManyTheFish 2023-11-23 14:43:52 +01:00
parent 84a36002d7
commit bddc168d83
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
milli/src/search/new/db_cache.rs
View File

@ -263,6 +263,7 @@ impl<'ctx> SearchContext<'ctx> {
word2: Interned<String>, word2: Interned<String>,
proximity: u8, proximity: u8,
) -> Result<Option<RoaringBitmap>> { ) -> Result<Option<RoaringBitmap>> {
// TODO: if database is empty, search if the word are in the same attribute instead
DatabaseCache::get_value::<_, _, CboRoaringBitmapCodec>( DatabaseCache::get_value::<_, _, CboRoaringBitmapCodec>(
self.txn, self.txn,
(proximity, word1, word2), (proximity, word1, word2),
@ -282,6 +283,7 @@ impl<'ctx> SearchContext<'ctx> {
word2: Interned<String>, word2: Interned<String>,
proximity: u8, proximity: u8,
) -> Result<Option<u64>> { ) -> Result<Option<u64>> {
// TODO: if database is empty, search if the word are in the same attribute instead
DatabaseCache::get_value::<_, _, CboRoaringBitmapLenCodec>( DatabaseCache::get_value::<_, _, CboRoaringBitmapLenCodec>(
self.txn, self.txn,
(proximity, word1, word2), (proximity, word1, word2),
@ -301,6 +303,7 @@ impl<'ctx> SearchContext<'ctx> {
prefix2: Interned<String>, prefix2: Interned<String>,
proximity: u8, proximity: u8,
) -> Result<Option<RoaringBitmap>> { ) -> Result<Option<RoaringBitmap>> {
// TODO: if database is empty, search if the word are in the same attribute instead
let docids = match self let docids = match self
.db_cache .db_cache
.word_prefix_pair_proximity_docids .word_prefix_pair_proximity_docids

2
milli/src/update/index_documents/extract/mod.rs
View File

@ -52,6 +52,7 @@ pub(crate) fn data_from_obkv_documents(
dictionary: Option<&[&str]>, dictionary: Option<&[&str]>,
max_positions_per_attributes: Option<u32>, max_positions_per_attributes: Option<u32>,
exact_attributes: HashSet<FieldId>, exact_attributes: HashSet<FieldId>,
// TODO: add a proximity database deactivation parameter.
) -> Result<()> { ) -> Result<()> {
puffin::profile_function!(); puffin::profile_function!();
@ -150,6 +151,7 @@ pub(crate) fn data_from_obkv_documents(
}); });
} }
// TODO: Skip this part if deactivated
spawn_extraction_task::<_, _, Vec<grenad::Reader<BufReader<File>>>>( spawn_extraction_task::<_, _, Vec<grenad::Reader<BufReader<File>>>>(
docid_word_positions_chunks.clone(), docid_word_positions_chunks.clone(),
indexer, indexer,

2
milli/src/update/settings.rs
View File

@ -127,6 +127,7 @@ pub struct Settings<'a, 't, 'i> {
max_values_per_facet: Setting<usize>, max_values_per_facet: Setting<usize>,
sort_facet_values_by: Setting<HashMap<String, OrderBy>>, sort_facet_values_by: Setting<HashMap<String, OrderBy>>,
pagination_max_total_hits: Setting<usize>, pagination_max_total_hits: Setting<usize>,
// TODO: add a proximity database deactivation attribute.
} }
impl<'a, 't, 'i> Settings<'a, 't, 'i> { impl<'a, 't, 'i> Settings<'a, 't, 'i> {
@ -906,6 +907,7 @@ impl<'a, 't, 'i> Settings<'a, 't, 'i> {
|| synonyms_updated || synonyms_updated
|| searchable_updated || searchable_updated
|| exact_attributes_updated || exact_attributes_updated
// TODO: reindex if proximity database is activated
{ {
self.reindex(&progress_callback, &should_abort, old_fields_ids_map)?; self.reindex(&progress_callback, &should_abort, old_fields_ids_map)?;
} }