snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-23 10:37:41 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Remove unused code

Browse Source
This commit is contained in:
Loïc Lecrenier 2022-08-31 08:39:01 +02:00 committed by Loïc Lecrenier
parent 39a4a0a362
commit bd2c0e1ab6
2 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
milli/src/search/facet/incremental_update.rs
View File

@ -43,8 +43,6 @@ impl<'i> IncrementalFacetUpdate<'i> {
.prefix_iter::<_, MyByteSlice, FacetGroupValueCodec>(txn, &prefix.as_slice())?; .prefix_iter::<_, MyByteSlice, FacetGroupValueCodec>(txn, &prefix.as_slice())?;
if let Some(e) = prefix_iter.next() { if let Some(e) = prefix_iter.next() {
let (key_bytes, value) = e?; let (key_bytes, value) = e?;
let key = FacetKeyCodec::<MyByteSlice>::bytes_decode(&key_bytes)
.ok_or(heed::Error::Encoding)?;
Ok(( Ok((
FacetKeyCodec::<MyByteSlice>::bytes_decode(&key_bytes) FacetKeyCodec::<MyByteSlice>::bytes_decode(&key_bytes)
.ok_or(Error::Encoding)? .ok_or(Error::Encoding)?

25
milli/src/update/index_documents/typed_chunk.rs
View File

@ -189,23 +189,14 @@ pub(crate) fn write_typed_chunk_into_index(
} }
} }
TypedChunk::FieldIdFacetStringDocids(facet_id_string_docids) => { TypedChunk::FieldIdFacetStringDocids(facet_id_string_docids) => {
append_entries_into_database( // facet_id_string_docids contains the thing that the extractor put into it,
facet_id_string_docids, // so: (FacetKey { field id, level: 0, left_bound } , docids: RoaringBitmap )
&index.facet_id_string_docids, // now we need to either:
wtxn, // 1. incrementally add the keys/docids pairs into the DB
index_is_empty, // 2. add the keys/docids into level 0 and then call Facets::execute
|value, _buffer| Ok(value), // the choice of solution should be determined by their performance
|new_values, db_values, buffer| { // characteristics
todo!()
// let (_, new_values) = decode_prefix_string(new_values).unwrap();
// let new_values = RoaringBitmap::deserialize_from(new_values)?;
// let (db_original, db_values) = decode_prefix_string(db_values).unwrap();
// let db_values = RoaringBitmap::deserialize_from(db_values)?;
// let values = new_values | db_values;
// encode_prefix_string(db_original, buffer)?;
// Ok(values.serialize_into(buffer)?)
},
)?;
is_merged_database = true; is_merged_database = true;
} }
TypedChunk::GeoPoints(geo_points) => { TypedChunk::GeoPoints(geo_points) => {