From bd2c0e1ab6393550d7cdd8439c9b605ff2dd7fce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Lecrenier?= Date: Wed, 31 Aug 2022 08:39:01 +0200 Subject: [PATCH] Remove unused code --- milli/src/search/facet/incremental_update.rs | 2 -- .../src/update/index_documents/typed_chunk.rs | 25 ++++++------------- 2 files changed, 8 insertions(+), 19 deletions(-) diff --git a/milli/src/search/facet/incremental_update.rs b/milli/src/search/facet/incremental_update.rs index a437efb2d..f01b19dab 100644 --- a/milli/src/search/facet/incremental_update.rs +++ b/milli/src/search/facet/incremental_update.rs @@ -43,8 +43,6 @@ impl<'i> IncrementalFacetUpdate<'i> { .prefix_iter::<_, MyByteSlice, FacetGroupValueCodec>(txn, &prefix.as_slice())?; if let Some(e) = prefix_iter.next() { let (key_bytes, value) = e?; - let key = FacetKeyCodec::::bytes_decode(&key_bytes) - .ok_or(heed::Error::Encoding)?; Ok(( FacetKeyCodec::::bytes_decode(&key_bytes) .ok_or(Error::Encoding)? diff --git a/milli/src/update/index_documents/typed_chunk.rs b/milli/src/update/index_documents/typed_chunk.rs index 7a9787bdb..3c7a78d95 100644 --- a/milli/src/update/index_documents/typed_chunk.rs +++ b/milli/src/update/index_documents/typed_chunk.rs @@ -189,23 +189,14 @@ pub(crate) fn write_typed_chunk_into_index( } } TypedChunk::FieldIdFacetStringDocids(facet_id_string_docids) => { - append_entries_into_database( - facet_id_string_docids, - &index.facet_id_string_docids, - wtxn, - index_is_empty, - |value, _buffer| Ok(value), - |new_values, db_values, buffer| { - todo!() - // let (_, new_values) = decode_prefix_string(new_values).unwrap(); - // let new_values = RoaringBitmap::deserialize_from(new_values)?; - // let (db_original, db_values) = decode_prefix_string(db_values).unwrap(); - // let db_values = RoaringBitmap::deserialize_from(db_values)?; - // let values = new_values | db_values; - // encode_prefix_string(db_original, buffer)?; - // Ok(values.serialize_into(buffer)?) - }, - )?; + // facet_id_string_docids contains the thing that the extractor put into it, + // so: (FacetKey { field id, level: 0, left_bound } , docids: RoaringBitmap ) + // now we need to either: + // 1. incrementally add the keys/docids pairs into the DB + // 2. add the keys/docids into level 0 and then call Facets::execute + // the choice of solution should be determined by their performance + // characteristics + is_merged_database = true; } TypedChunk::GeoPoints(geo_points) => {