snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-30 09:04:59 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

edit the two lasts TODO comments

Browse Source
This commit is contained in:
Tamo 2021-09-08 18:12:10 +02:00
parent b15c77ebc4
commit bad8ea47d5
No known key found for this signature in database
GPG Key ID: 20CD8020AFA88D69
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
milli/src/update/index_documents/extract/extract_geo_points.rs
View File

@ -33,7 +33,8 @@ pub fn extract_geo_points<R: io::Read>(
let bytes: [u8; 16] = concat_arrays![lat.to_ne_bytes(), lng.to_ne_bytes()]; let bytes: [u8; 16] = concat_arrays![lat.to_ne_bytes(), lng.to_ne_bytes()];
writer.insert(docid_bytes, bytes)?; writer.insert(docid_bytes, bytes)?;
} else { } else {
let primary_key = obkv.get(primary_key_id).unwrap(); // TODO: TAMO: is this valid? // All document must have a primary key so we can unwrap safely here
let primary_key = obkv.get(primary_key_id).unwrap();
let primary_key = let primary_key =
serde_json::from_slice(primary_key).map_err(InternalError::SerdeJson)?; serde_json::from_slice(primary_key).map_err(InternalError::SerdeJson)?;
Err(UserError::InvalidGeoField { document_id: primary_key, object: point })? Err(UserError::InvalidGeoField { document_id: primary_key, object: point })?

2
milli/src/update/index_documents/mod.rs
View File

@ -229,7 +229,7 @@ impl<'t, 'u, 'i, 'a> IndexDocuments<'t, 'u, 'i, 'a> {
) = crossbeam_channel::unbounded(); ) = crossbeam_channel::unbounded();
// get the primary key field id // get the primary key field id
let primary_key_id = fields_ids_map.id(&primary_key).unwrap(); // TODO: TAMO: is this unwrap 100% valid? let primary_key_id = fields_ids_map.id(&primary_key).unwrap();
// get searchable fields for word databases // get searchable fields for word databases
let searchable_fields = let searchable_fields =