snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-26 12:05:05 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

fix comments

Browse Source
This commit is contained in:
Tamo 2024-09-24 10:59:15 +02:00
parent fd8447c521
commit b8a74e0464
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
milli/src/vector/mod.rs
View File

@ -115,7 +115,10 @@ impl ArroyWrapper {
Ok(()) Ok(())
} }
/// Overwrite all the embeddings associated to the index and item id. /// Overwrite all the embeddings associated with the index and item ID.
/// /!\ It won't remove embeddings after the last passed embedding, which can leave stale embeddings.
/// You should call `del_items` on the `item_id` before calling this method.
/// /!\ Cannot insert more than u8::MAX embeddings; after inserting u8::MAX embeddings, all the remaining ones will be silently ignored.
pub fn add_items( pub fn add_items(
&self, &self,
wtxn: &mut RwTxn, wtxn: &mut RwTxn,
@ -243,7 +246,6 @@ impl ArroyWrapper {
last_index_with_a_vector = Some((index, candidate)); last_index_with_a_vector = Some((index, candidate));
} }
if let Some((last_index, vector)) = last_index_with_a_vector { if let Some((last_index, vector)) = last_index_with_a_vector {
// unwrap: computed the index from the list of writers
let writer = arroy::Writer::new(db, last_index, dimension); let writer = arroy::Writer::new(db, last_index, dimension);
writer.del_item(wtxn, item_id)?; writer.del_item(wtxn, item_id)?;
let writer = arroy::Writer::new(db, deleted_index, dimension); let writer = arroy::Writer::new(db, deleted_index, dimension);