snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-02-12 22:00:06 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Change the updated* functions to only_new functions, hopefully better communicating what they do

Browse Source
This commit is contained in:
Louis Dureuil 2025-02-11 15:24:50 +01:00
parent d7f35ee3ba
commit b83275c9c5
No known key found for this signature in database
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/milli/src/update/new/document_change.rs
View File

@ -144,7 +144,7 @@ impl<'doc> Update<'doc> {
)?) )?)
} }
pub fn updated(&self) -> DocumentFromVersions<'_, 'doc> { pub fn only_changed_fields(&self) -> DocumentFromVersions<'_, 'doc> {
DocumentFromVersions::new(&self.new) DocumentFromVersions::new(&self.new)
} }
@ -182,7 +182,7 @@ impl<'doc> Update<'doc> {
let mut cached_current = None; let mut cached_current = None;
let mut updated_selected_field_count = 0; let mut updated_selected_field_count = 0;
for entry in self.updated().iter_top_level_fields() { for entry in self.only_changed_fields().iter_top_level_fields() {
let (key, updated_value) = entry?; let (key, updated_value) = entry?;
if perm_json_p::select_field(key, fields, &[]) == perm_json_p::Selection::Skip { if perm_json_p::select_field(key, fields, &[]) == perm_json_p::Selection::Skip {
@ -241,7 +241,7 @@ impl<'doc> Update<'doc> {
Ok(has_deleted_fields) Ok(has_deleted_fields)
} }
pub fn updated_vectors( pub fn only_changed_vectors(
&self, &self,
doc_alloc: &'doc Bump, doc_alloc: &'doc Bump,
embedders: &'doc EmbeddingConfigs, embedders: &'doc EmbeddingConfigs,

3
crates/milli/src/update/new/extract/vectors/mod.rs
View File

@ -99,7 +99,8 @@ impl<'a, 'b, 'extractor> Extractor<'extractor> for EmbeddingExtractor<'a, 'b> {
context.db_fields_ids_map, context.db_fields_ids_map,
&context.doc_alloc, &context.doc_alloc,
)?; )?;
let new_vectors = update.updated_vectors(&context.doc_alloc, self.embedders)?; let new_vectors =
update.only_changed_vectors(&context.doc_alloc, self.embedders)?;
if let Some(new_vectors) = &new_vectors { if let Some(new_vectors) = &new_vectors {
unused_vectors_distribution.append(new_vectors)?; unused_vectors_distribution.append(new_vectors)?;