diff --git a/crates/meilisearch/tests/common/mod.rs b/crates/meilisearch/tests/common/mod.rs index afbd5a2f5..a0137931d 100644 --- a/crates/meilisearch/tests/common/mod.rs +++ b/crates/meilisearch/tests/common/mod.rs @@ -389,3 +389,25 @@ pub static VECTOR_DOCUMENTS: Lazy = Lazy::new(|| { }, ]) }); + +pub async fn shared_index_with_test_set() -> &'static Index<'static, Shared> { + static INDEX: OnceCell> = OnceCell::const_new(); + INDEX + .get_or_init(|| async { + let server = Server::new_shared(); + let index = server._index("SHARED_TEST_SET").to_shared(); + let url = format!("/indexes/{}/documents", urlencoding::encode(index.uid.as_ref())); + let (response, code) = index + .service + .post_str( + url, + include_str!("../assets/test_set.json"), + vec![("content-type", "application/json")], + ) + .await; + assert_eq!(code, 202); + index.wait_task(response.uid()).await; + index + }) + .await +} diff --git a/crates/meilisearch/tests/documents/get_documents.rs b/crates/meilisearch/tests/documents/get_documents.rs index e77165f8b..d66d36c56 100644 --- a/crates/meilisearch/tests/documents/get_documents.rs +++ b/crates/meilisearch/tests/documents/get_documents.rs @@ -4,24 +4,27 @@ use meili_snap::*; use urlencoding::encode as urlencode; use crate::common::encoder::Encoder; -use crate::common::{GetAllDocumentsOptions, Server, Value}; +use crate::common::{ + shared_does_not_exists_index, shared_empty_index, shared_index_with_test_set, + GetAllDocumentsOptions, Server, Value, +}; use crate::json; // TODO: partial test since we are testing error, amd error is not yet fully implemented in // transplant #[actix_rt::test] async fn get_unexisting_index_single_document() { - let server = Server::new().await; - let (_response, code) = server.index("test").get_document(1, None).await; + let (_response, code) = shared_does_not_exists_index().await.get_document(1, None).await; assert_eq!(code, 404); } #[actix_rt::test] async fn error_get_unexisting_document() { - let server = Server::new().await; - let index = server.index("test"); - index.create(None).await; - index.wait_task(0).await; + let server = Server::new_shared(); + let index = server.unique_index(); + let (task, _code) = index.create(None).await; + index.wait_task(task.uid()).await.succeeded(); + let (response, code) = index.get_document(1, None).await; let expected_response = json!({ @@ -37,18 +40,19 @@ async fn error_get_unexisting_document() { #[actix_rt::test] async fn get_document() { - let server = Server::new().await; - let index = server.index("test"); - index.create(None).await; + let server = Server::new_shared(); + let index = server.unique_index(); + let (task, _code) = index.create(None).await; + index.wait_task(task.uid()).await.succeeded(); let documents = json!([ { "id": 0, "nested": { "content": "foobar" }, } ]); - let (_, code) = index.add_documents(documents, None).await; + let (task, code) = index.add_documents(documents, None).await; assert_eq!(code, 202); - index.wait_task(1).await; + index.wait_task(task.uid()).await.succeeded(); let (response, code) = index.get_document(0, None).await; assert_eq!(code, 200); assert_eq!( @@ -81,12 +85,11 @@ async fn get_document() { #[actix_rt::test] async fn error_get_unexisting_index_all_documents() { - let server = Server::new().await; - let (response, code) = - server.index("test").get_all_documents(GetAllDocumentsOptions::default()).await; + let index = shared_does_not_exists_index().await; + let (response, code) = index.get_all_documents(GetAllDocumentsOptions::default()).await; let expected_response = json!({ - "message": "Index `test` not found.", + "message": "Index `DOES_NOT_EXISTS` not found.", "code": "index_not_found", "type": "invalid_request", "link": "https://docs.meilisearch.com/errors#index_not_found" @@ -98,12 +101,7 @@ async fn error_get_unexisting_index_all_documents() { #[actix_rt::test] async fn get_no_document() { - let server = Server::new().await; - let index = server.index("test"); - let (_, code) = index.create(None).await; - assert_eq!(code, 202); - - index.wait_task(0).await; + let index = shared_empty_index().await; let (response, code) = index.get_all_documents(GetAllDocumentsOptions::default()).await; assert_eq!(code, 200); @@ -112,14 +110,12 @@ async fn get_no_document() { #[actix_rt::test] async fn get_all_documents_no_options() { - let server = Server::new().await; - let index = server.index("test"); - index.load_test_set().await; + let index = shared_index_with_test_set().await; let (response, code) = index.get_all_documents(GetAllDocumentsOptions::default()).await; assert_eq!(code, 200); - let arr = response["results"].as_array().unwrap(); - assert_eq!(arr.len(), 20); + let results = response["results"].as_array().unwrap(); + assert_eq!(results.len(), 20); let first = json!({ "id":0, "isActive":false, @@ -138,19 +134,16 @@ async fn get_all_documents_no_options() { "longitude":-145.725388, "tags":["bug" ,"bug"]}); - assert_eq!(first, arr[0]); + assert_eq!(first, results[0]); } #[actix_rt::test] async fn get_all_documents_no_options_with_response_compression() { - let server = Server::new().await; - let index_uid = "test"; - let index = server.index(index_uid); - index.load_test_set().await; + let index = shared_index_with_test_set().await; - let app = server.init_web_app().await; + let app = Server::new_shared().init_web_app().await; let req = test::TestRequest::get() - .uri(&format!("/indexes/{}/documents?", urlencode(index_uid))) + .uri(&format!("/indexes/{}/documents?", urlencode(&index.uid))) .insert_header((ACCEPT_ENCODING, "gzip")) .to_request(); @@ -169,9 +162,7 @@ async fn get_all_documents_no_options_with_response_compression() { #[actix_rt::test] async fn test_get_all_documents_limit() { - let server = Server::new().await; - let index = server.index("test"); - index.load_test_set().await; + let index = shared_index_with_test_set().await; let (response, code) = index .get_all_documents(GetAllDocumentsOptions { limit: Some(5), ..Default::default() }) @@ -186,9 +177,7 @@ async fn test_get_all_documents_limit() { #[actix_rt::test] async fn test_get_all_documents_offset() { - let server = Server::new().await; - let index = server.index("test"); - index.load_test_set().await; + let index = shared_index_with_test_set().await; let (response, code) = index .get_all_documents(GetAllDocumentsOptions { offset: Some(5), ..Default::default() }) @@ -203,9 +192,7 @@ async fn test_get_all_documents_offset() { #[actix_rt::test] async fn test_get_all_documents_attributes_to_retrieve() { - let server = Server::new().await; - let index = server.index("test"); - index.load_test_set().await; + let index = shared_index_with_test_set().await; let (response, code) = index .get_all_documents(GetAllDocumentsOptions { @@ -286,9 +273,11 @@ async fn test_get_all_documents_attributes_to_retrieve() { #[actix_rt::test] async fn get_document_s_nested_attributes_to_retrieve() { - let server = Server::new().await; - let index = server.index("test"); - index.create(None).await; + let server = Server::new_shared(); + let index = server.unique_index(); + let (task, _code) = index.create(None).await; + index.wait_task(task.uid()).await.succeeded(); + let documents = json!([ { "id": 0, @@ -302,9 +291,9 @@ async fn get_document_s_nested_attributes_to_retrieve() { }, }, ]); - let (_, code) = index.add_documents(documents, None).await; + let (task, code) = index.add_documents(documents, None).await; assert_eq!(code, 202); - index.wait_task(1).await; + index.wait_task(task.uid()).await.succeeded(); let (response, code) = index.get_document(0, Some(json!({ "fields": ["content"] }))).await; assert_eq!(code, 200); @@ -343,10 +332,10 @@ async fn get_document_s_nested_attributes_to_retrieve() { #[actix_rt::test] async fn get_documents_displayed_attributes_is_ignored() { - let server = Server::new().await; - let index = server.index("test"); - index.update_settings(json!({"displayedAttributes": ["gender"]})).await; + let server = Server::new_shared(); + let index = server.unique_index(); index.load_test_set().await; + index.update_settings(json!({"displayedAttributes": ["gender"]})).await; let (response, code) = index.get_all_documents(GetAllDocumentsOptions::default()).await; assert_eq!(code, 200); @@ -366,10 +355,10 @@ async fn get_documents_displayed_attributes_is_ignored() { #[actix_rt::test] async fn get_document_by_filter() { - let server = Server::new().await; - let index = server.index("doggo"); + let server = Server::new_shared(); + let index = server.unique_index(); index.update_settings_filterable_attributes(json!(["color"])).await; - index + let (task, _code) = index .add_documents( json!([ { "id": 0, "color": "red" }, @@ -380,7 +369,7 @@ async fn get_document_by_filter() { Some("id"), ) .await; - index.wait_task(1).await; + index.wait_task(task.uid()).await.succeeded(); let (response, code) = index.get_document_by_filter(json!({})).await; let (response2, code2) = index.get_all_documents_raw("").await; @@ -552,7 +541,7 @@ async fn get_document_with_vectors() { })) .await; snapshot!(code, @"202 Accepted"); - server.wait_task(response.uid()).await; + server.wait_task(response.uid()).await.succeeded(); let documents = json!([ {"id": 0, "name": "kefir", "_vectors": { "manual": [0, 0, 0] }}, @@ -560,7 +549,7 @@ async fn get_document_with_vectors() { ]); let (value, code) = index.add_documents(documents, None).await; snapshot!(code, @"202 Accepted"); - index.wait_task(value.uid()).await; + index.wait_task(value.uid()).await.succeeded(); // by default you shouldn't see the `_vectors` object let (documents, _code) = index.get_all_documents(Default::default()).await;