From b11df7ec341ba5987e2be644a008c6b5937666e9 Mon Sep 17 00:00:00 2001 From: Louis Dureuil Date: Mon, 26 Feb 2024 16:38:17 +0100 Subject: [PATCH] Meilisearch: fix some wrong spans --- milli/src/update/index_documents/extract/mod.rs | 3 +-- milli/src/update/index_documents/mod.rs | 2 +- milli/src/update/index_documents/typed_chunk.rs | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/milli/src/update/index_documents/extract/mod.rs b/milli/src/update/index_documents/extract/mod.rs index 251a2db99..43f3f4947 100644 --- a/milli/src/update/index_documents/extract/mod.rs +++ b/milli/src/update/index_documents/extract/mod.rs @@ -210,8 +210,7 @@ fn run_extraction_task( let current_span = tracing::Span::current(); rayon::spawn(move || { - let child_span = - tracing::trace_span!(target: "", parent: ¤t_span, "extract_multiple_chunks"); + let child_span = tracing::trace_span!(target: "indexing::extract::details", parent: ¤t_span, "extract_multiple_chunks"); let _entered = child_span.enter(); puffin::profile_scope!("extract_multiple_chunks", name); match extract_fn(chunk, indexer) { diff --git a/milli/src/update/index_documents/mod.rs b/milli/src/update/index_documents/mod.rs index 61ca1a024..7499b68e5 100644 --- a/milli/src/update/index_documents/mod.rs +++ b/milli/src/update/index_documents/mod.rs @@ -284,7 +284,7 @@ where #[tracing::instrument( level = "trace", skip_all, - target = "profile::indexing::details", + target = "indexing::details", name = "index_documents_raw" )] pub fn execute_raw(self, output: TransformOutput) -> Result diff --git a/milli/src/update/index_documents/typed_chunk.rs b/milli/src/update/index_documents/typed_chunk.rs index 1fea9a70f..6aad290e5 100644 --- a/milli/src/update/index_documents/typed_chunk.rs +++ b/milli/src/update/index_documents/typed_chunk.rs @@ -473,7 +473,7 @@ pub(crate) fn write_typed_chunk_into_index( is_merged_database = true; } TypedChunk::FieldIdFacetIsEmptyDocids(_) => { - let span = tracing::trace_span!(target: "profile::indexing::write_db", "field_id_facet_is_empty_docids"); + let span = tracing::trace_span!(target: "indexing::write_db", "field_id_facet_is_empty_docids"); let _entered = span.enter(); let mut builder = MergerBuilder::new(merge_deladd_cbo_roaring_bitmaps as MergeFn);