fix clippy error and remove clippy job from ci

Remove clippy job

Fix clippy error type_complexity

Restore ambiguous change
This commit is contained in:
unvalley 2022-10-28 22:07:18 +09:00
parent f3c0b05ae8
commit a1d7ed1258
3 changed files with 8 additions and 21 deletions

View File

@ -48,24 +48,6 @@ jobs:
command: test
args: --release
clippy:
name: Run Clippy
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
override: true
components: clippy
- name: Cache dependencies
uses: Swatinem/rust-cache@v2.0.0
- name: Run cargo clippy
uses: actions-rs/cargo@v1
with:
command: clippy
fmt:
name: Run Rustfmt
runs-on: ubuntu-20.04

View File

@ -2,7 +2,6 @@ status = [
'Tests on ubuntu-20.04',
'Tests on macos-latest',
'Tests on windows-latest',
'Run Clippy',
'Run Rustfmt',
]
# 3 hours timeout

View File

@ -196,7 +196,10 @@ impl<R: std::io::Read + std::io::Seek> FacetsUpdateBulkInner<R> {
&self,
rtxn: &'t RoTxn,
field_id: u16,
handle_group: &mut dyn FnMut(&[RoaringBitmap], &'t [u8]) -> Result<()>,
#[allow(clippy::type_complexity)] handle_group: &mut dyn FnMut(
&[RoaringBitmap],
&'t [u8],
) -> Result<()>,
) -> Result<()> {
// we read the elements one by one and
// 1. keep track of the left bound
@ -250,7 +253,10 @@ impl<R: std::io::Read + std::io::Seek> FacetsUpdateBulkInner<R> {
rtxn: &'t RoTxn,
field_id: u16,
level: u8,
handle_group: &mut dyn FnMut(&[RoaringBitmap], &'t [u8]) -> Result<()>,
#[allow(clippy::type_complexity)] handle_group: &mut dyn FnMut(
&[RoaringBitmap],
&'t [u8],
) -> Result<()>,
) -> Result<Vec<grenad::Reader<File>>> {
if level == 0 {
self.read_level_0(rtxn, field_id, handle_group)?;