From 09e71fdeb65f9e68d34cd163b7c7f373514be2c8 Mon Sep 17 00:00:00 2001 From: funilrys Date: Mon, 31 Oct 2022 22:23:16 +0100 Subject: [PATCH 1/8] Replace deprecated set-output in GitHub actions This patch fixes #3011. This patch fixes the depracation warning regarding the usage of `set-output`. This patch fixes the issues by switching the following format: ``` echo ::set-output name=[name]::[value] ``` into the following format: ``` echo "[name]=[value]" >> ${GITHUB_OUTPUT} ``` --- .github/workflows/milestone-workflow.yml | 5 +++-- .github/workflows/publish-binaries.yml | 6 +++--- .github/workflows/publish-docker-images.yml | 8 ++++---- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/milestone-workflow.yml b/.github/workflows/milestone-workflow.yml index b8a2a1662..b77582ec8 100644 --- a/.github/workflows/milestone-workflow.yml +++ b/.github/workflows/milestone-workflow.yml @@ -41,10 +41,11 @@ jobs: echo version: $MILESTONE_VERSION if [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.0$ ]]; then echo 'This is NOT a patch release' - echo ::set-output name=is-patch::false + echo "is-patch=false" >> ${GITHUB_OUTPUT} + elif [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then echo 'This is a patch release' - echo ::set-output name=is-patch::true + echo "is-patch=true" >> ${GITHUB_OUTPUT} else echo "Not a valid format of release, check the Milestone's title." echo 'Should be vX.Y.Z' diff --git a/.github/workflows/publish-binaries.yml b/.github/workflows/publish-binaries.yml index 83abda384..abad55f0e 100644 --- a/.github/workflows/publish-binaries.yml +++ b/.github/workflows/publish-binaries.yml @@ -23,9 +23,9 @@ jobs: escaped_tag=$(printf "%q" ${{ github.ref_name }}) if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then - echo ::set-output name=stable::true + echo "stable=true" >> ${GITHUB_OUTPUT} else - echo ::set-output name=stable::false + echo "stable=false" >> ${GITHUB_OUTPUT} fi - name: Check release validity if: github.event_name != 'schedule' && steps.check-tag-format.outputs.stable == 'true' @@ -66,7 +66,7 @@ jobs: file: target/release/${{ matrix.artifact_name }} asset_name: ${{ matrix.asset_name }} tag: ${{ github.ref }} - + publish-macos-apple-silicon: name: Publish binary for macOS silicon runs-on: ${{ matrix.os }} diff --git a/.github/workflows/publish-docker-images.yml b/.github/workflows/publish-docker-images.yml index ab5e7131d..2fc4354aa 100644 --- a/.github/workflows/publish-docker-images.yml +++ b/.github/workflows/publish-docker-images.yml @@ -1,10 +1,10 @@ --- on: schedule: - - cron: '0 4 * * *' # Every day at 4:00am + - cron: "0 4 * * *" # Every day at 4:00am push: tags: - - '*' + - "*" name: Publish tagged images to Docker Hub @@ -25,9 +25,9 @@ jobs: escaped_tag=$(printf "%q" ${{ github.ref_name }}) if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then - echo ::set-output name=stable::true + echo "stable=true" >> ${GITHUB_OUTPUT} else - echo ::set-output name=stable::false + echo "stable=false" >> ${GITHUB_OUTPUT} fi # Check only the validity of the tag for official releases (not for pre-releases or other tags) From 72c4db45539c73114d80e07cdf779a57982d6208 Mon Sep 17 00:00:00 2001 From: funilrys Date: Tue, 8 Nov 2022 21:15:28 +0100 Subject: [PATCH 2/8] Rewrite: ${GITHUB_OUTPUT} -> $GITHUB_OUTPUT. --- .github/workflows/milestone-workflow.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/milestone-workflow.yml b/.github/workflows/milestone-workflow.yml index b77582ec8..b51c202cb 100644 --- a/.github/workflows/milestone-workflow.yml +++ b/.github/workflows/milestone-workflow.yml @@ -41,11 +41,11 @@ jobs: echo version: $MILESTONE_VERSION if [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.0$ ]]; then echo 'This is NOT a patch release' - echo "is-patch=false" >> ${GITHUB_OUTPUT} + echo "is-patch=false" >> $GITHUB_OUTPUT elif [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then echo 'This is a patch release' - echo "is-patch=true" >> ${GITHUB_OUTPUT} + echo "is-patch=true" >> $GITHUB_OUTPUT else echo "Not a valid format of release, check the Milestone's title." echo 'Should be vX.Y.Z' From 7331da0410897db2a9cfb22cf8b131377d03f837 Mon Sep 17 00:00:00 2001 From: funilrys Date: Tue, 8 Nov 2022 21:16:47 +0100 Subject: [PATCH 3/8] Fix auto-formater issue. Indeed, my editor always fixes the format for me. That's why those 2 lines were changed. --- .github/workflows/publish-docker-images.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-docker-images.yml b/.github/workflows/publish-docker-images.yml index 2fc4354aa..70a7527d4 100644 --- a/.github/workflows/publish-docker-images.yml +++ b/.github/workflows/publish-docker-images.yml @@ -1,10 +1,10 @@ --- on: schedule: - - cron: "0 4 * * *" # Every day at 4:00am + - cron: '0 4 * * *' # Every day at 4:00am push: tags: - - "*" + - '*' name: Publish tagged images to Docker Hub From a441fe5ae517f237e9430262f03fc98d31f4d619 Mon Sep 17 00:00:00 2001 From: funilrys Date: Tue, 8 Nov 2022 21:18:24 +0100 Subject: [PATCH 4/8] Remove unecessary line. --- .github/workflows/milestone-workflow.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/milestone-workflow.yml b/.github/workflows/milestone-workflow.yml index b51c202cb..3a49b342b 100644 --- a/.github/workflows/milestone-workflow.yml +++ b/.github/workflows/milestone-workflow.yml @@ -42,7 +42,6 @@ jobs: if [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.0$ ]]; then echo 'This is NOT a patch release' echo "is-patch=false" >> $GITHUB_OUTPUT - elif [[ $MILESTONE_VERSION =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then echo 'This is a patch release' echo "is-patch=true" >> $GITHUB_OUTPUT From c05abc2b0de7416954720d99830f30f1e73d8bda Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9mentine=20Urquizar=20-=20curqui?= Date: Thu, 10 Nov 2022 10:40:04 +0100 Subject: [PATCH 5/8] Update .github/workflows/publish-binaries.yml --- .github/workflows/publish-binaries.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-binaries.yml b/.github/workflows/publish-binaries.yml index abad55f0e..72ea1745f 100644 --- a/.github/workflows/publish-binaries.yml +++ b/.github/workflows/publish-binaries.yml @@ -25,7 +25,7 @@ jobs: if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then echo "stable=true" >> ${GITHUB_OUTPUT} else - echo "stable=false" >> ${GITHUB_OUTPUT} + echo "stable=false" >> $GITHUB_OUTPUT fi - name: Check release validity if: github.event_name != 'schedule' && steps.check-tag-format.outputs.stable == 'true' From 8d79f501f3cf8b7a4c3af3c5f7b1b93e7e2ee65f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9mentine=20Urquizar=20-=20curqui?= Date: Thu, 10 Nov 2022 10:40:09 +0100 Subject: [PATCH 6/8] Update .github/workflows/publish-binaries.yml --- .github/workflows/publish-binaries.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-binaries.yml b/.github/workflows/publish-binaries.yml index 72ea1745f..beca21a00 100644 --- a/.github/workflows/publish-binaries.yml +++ b/.github/workflows/publish-binaries.yml @@ -23,7 +23,7 @@ jobs: escaped_tag=$(printf "%q" ${{ github.ref_name }}) if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then - echo "stable=true" >> ${GITHUB_OUTPUT} + echo "stable=true" >> $GITHUB_OUTPUT else echo "stable=false" >> $GITHUB_OUTPUT fi From 32cd9e4852355932c90718886a4187868fcef66f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9mentine=20Urquizar=20-=20curqui?= Date: Thu, 10 Nov 2022 10:40:16 +0100 Subject: [PATCH 7/8] Update .github/workflows/publish-docker-images.yml --- .github/workflows/publish-docker-images.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-docker-images.yml b/.github/workflows/publish-docker-images.yml index 70a7527d4..d48804eef 100644 --- a/.github/workflows/publish-docker-images.yml +++ b/.github/workflows/publish-docker-images.yml @@ -25,7 +25,7 @@ jobs: escaped_tag=$(printf "%q" ${{ github.ref_name }}) if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then - echo "stable=true" >> ${GITHUB_OUTPUT} + echo "stable=true" >> $GITHUB_OUTPUT else echo "stable=false" >> ${GITHUB_OUTPUT} fi From fe980f9e88cdfa163feeab1869fc78f927b42b77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9mentine=20Urquizar=20-=20curqui?= Date: Thu, 10 Nov 2022 10:40:21 +0100 Subject: [PATCH 8/8] Update .github/workflows/publish-docker-images.yml --- .github/workflows/publish-docker-images.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-docker-images.yml b/.github/workflows/publish-docker-images.yml index d48804eef..3abe9ce47 100644 --- a/.github/workflows/publish-docker-images.yml +++ b/.github/workflows/publish-docker-images.yml @@ -27,7 +27,7 @@ jobs: if [[ $escaped_tag =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then echo "stable=true" >> $GITHUB_OUTPUT else - echo "stable=false" >> ${GITHUB_OUTPUT} + echo "stable=false" >> $GITHUB_OUTPUT fi # Check only the validity of the tag for official releases (not for pre-releases or other tags)