From 935a724c570b3b851da544b96734ce20cf280f2c Mon Sep 17 00:00:00 2001
From: Gregory Conrad <gregorysconrad@gmail.com>
Date: Thu, 24 Nov 2022 10:08:23 -0500
Subject: [PATCH] revert: Revert pass by reference API change

---
 cli/src/main.rs              | 2 +-
 milli/src/lib.rs             | 6 +++---
 milli/src/update/settings.rs | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/cli/src/main.rs b/cli/src/main.rs
index f2bbc0b23..dd5489ebc 100644
--- a/cli/src/main.rs
+++ b/cli/src/main.rs
@@ -450,7 +450,7 @@ impl Search {
         let documents = index.documents(&txn, result.documents_ids)?;
         let mut jsons = Vec::new();
         for (_, obkv) in documents {
-            let json = milli::obkv_to_json(&displayed_fields, &fields_ids_map, &obkv)?;
+            let json = milli::obkv_to_json(&displayed_fields, &fields_ids_map, obkv)?;
             jsons.push(json);
         }
 
diff --git a/milli/src/lib.rs b/milli/src/lib.rs
index 7d74637f2..21851430e 100644
--- a/milli/src/lib.rs
+++ b/milli/src/lib.rs
@@ -88,7 +88,7 @@ pub fn absolute_from_relative_position(field_id: FieldId, relative: RelativePosi
 pub fn obkv_to_json(
     displayed_fields: &[FieldId],
     fields_ids_map: &FieldsIdsMap,
-    obkv: &obkv::KvReaderU16,
+    obkv: obkv::KvReaderU16,
 ) -> Result<Object> {
     displayed_fields
         .iter()
@@ -106,7 +106,7 @@ pub fn obkv_to_json(
 }
 
 /// Transform every field of a raw obkv store into a JSON Object.
-pub fn all_obkv_to_json(obkv: &obkv::KvReaderU16, fields_ids_map: &FieldsIdsMap) -> Result<Object> {
+pub fn all_obkv_to_json(obkv: obkv::KvReaderU16, fields_ids_map: &FieldsIdsMap) -> Result<Object> {
     let all_keys = obkv.iter().map(|(k, _v)| k).collect::<Vec<_>>();
     obkv_to_json(all_keys.as_slice(), fields_ids_map, obkv)
 }
@@ -309,7 +309,7 @@ mod tests {
             "field2": 4321,
         });
         let expected = expected.as_object().unwrap();
-        let actual = all_obkv_to_json(&obkv, &fields_ids_map).unwrap();
+        let actual = all_obkv_to_json(obkv, &fields_ids_map).unwrap();
 
         assert_eq!(&actual, expected);
     }
diff --git a/milli/src/update/settings.rs b/milli/src/update/settings.rs
index eb5f56c45..6da32d73f 100644
--- a/milli/src/update/settings.rs
+++ b/milli/src/update/settings.rs
@@ -920,7 +920,7 @@ mod tests {
         let fidmap = index.fields_ids_map(&rtxn).unwrap();
         for document in index.all_documents(&rtxn).unwrap() {
             let document = document.unwrap();
-            let json = crate::obkv_to_json(&fidmap.ids().collect::<Vec<_>>(), &fidmap, &document.1)
+            let json = crate::obkv_to_json(&fidmap.ids().collect::<Vec<_>>(), &fidmap, document.1)
                 .unwrap();
             println!("json: {:?}", json);
         }