From 849de089d2efca18aa2efb8f0dcdc440bc0f6f36 Mon Sep 17 00:00:00 2001
From: Filip Bachul <filipbachul@gmail.com>
Date: Tue, 14 Feb 2023 00:08:42 +0100
Subject: [PATCH] add thiserror for AscDescError

---
 milli/src/asc_desc.rs | 24 ++++--------------------
 1 file changed, 4 insertions(+), 20 deletions(-)

diff --git a/milli/src/asc_desc.rs b/milli/src/asc_desc.rs
index 3d6ec2d24..f8595a0ee 100644
--- a/milli/src/asc_desc.rs
+++ b/milli/src/asc_desc.rs
@@ -12,10 +12,13 @@ use crate::{CriterionError, Error, UserError};
 
 /// This error type is never supposed to be shown to the end user.
 /// You must always cast it to a sort error or a criterion error.
-#[derive(Debug)]
+#[derive(Error, Debug)]
 pub enum AscDescError {
+    #[error(transparent)]
     GeoError(ParseGeoError),
+    #[error("Invalid syntax for the asc/desc parameter: expected expression ending by `:asc` or `:desc`, found `{name}`.")]
     InvalidSyntax { name: String },
+    #[error("`{name}` is a reserved keyword and thus can't be used as a asc/desc rule.")]
     ReservedKeyword { name: String },
 }
 
@@ -25,25 +28,6 @@ impl From<ParseGeoError> for AscDescError {
     }
 }
 
-impl fmt::Display for AscDescError {
-    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
-        match self {
-            Self::GeoError(error) => {
-                write!(f, "{error}",)
-            }
-            Self::InvalidSyntax { name } => {
-                write!(f, "Invalid syntax for the asc/desc parameter: expected expression ending by `:asc` or `:desc`, found `{}`.", name)
-            }
-            Self::ReservedKeyword { name } => {
-                write!(
-                    f,
-                    "`{}` is a reserved keyword and thus can't be used as a asc/desc rule.",
-                    name
-                )
-            }
-        }
-    }
-}
 
 impl From<AscDescError> for CriterionError {
     fn from(error: AscDescError) -> Self {