From 7f92116b516b174f5c0009caadd3a1eabad28ff8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Renault?= <clement@meilisearch.com>
Date: Wed, 31 Aug 2022 10:56:39 +0200
Subject: [PATCH] Accept again integers as document ids

---
 milli/src/documents/builder.rs | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/milli/src/documents/builder.rs b/milli/src/documents/builder.rs
index 1a57db34b..9fda31cf0 100644
--- a/milli/src/documents/builder.rs
+++ b/milli/src/documents/builder.rs
@@ -118,6 +118,8 @@ impl<W: Write> DocumentsBatchBuilder<W> {
                     AllowedType::Number => {
                         if value.trim().is_empty() {
                             to_writer(&mut self.value_buffer, &Value::Null)?;
+                        } else if let Ok(integer) = value.trim().parse::<i64>() {
+                            to_writer(&mut self.value_buffer, &integer)?;
                         } else {
                             match value.trim().parse::<f64>() {
                                 Ok(float) => {
@@ -359,7 +361,34 @@ mod test {
             json!({
                 "city": "Boston",
                 "country": "United States",
-                "pop": 4628910.0,
+                "pop": 4628910,
+            })
+        );
+    }
+
+    #[test]
+    fn integer_as_id() {
+        let csv_content = r#""id:number","title:string","comment:string"
+"1239","Pride and Prejudice","A great book""#;
+        let csv = csv::Reader::from_reader(Cursor::new(csv_content));
+
+        let mut builder = DocumentsBatchBuilder::new(Vec::new());
+        builder.append_csv(csv).unwrap();
+        let vector = builder.into_inner().unwrap();
+
+        let (mut cursor, index) = DocumentsBatchReader::from_reader(Cursor::new(vector))
+            .unwrap()
+            .into_cursor_and_fields_index();
+
+        let doc = cursor.next_document().unwrap().unwrap();
+        let val = obkv_to_object(&doc, &index).map(Value::from).unwrap();
+
+        assert_eq!(
+            val,
+            json!({
+                "id": 1239,
+                "title": "Pride and Prejudice",
+                "comment": "A great book",
             })
         );
     }