bug(lib): fix get dumps bad error code

This commit is contained in:
Marin Postma 2021-12-15 10:30:00 +01:00
parent 5af51c852c
commit 7ddab7ef31
3 changed files with 28 additions and 4 deletions

View File

@ -1,3 +1,4 @@
#![allow(dead_code)]
use std::path::Path; use std::path::Path;
use actix_web::http::StatusCode; use actix_web::http::StatusCode;
@ -88,6 +89,10 @@ impl Server {
pub async fn tasks(&self) -> (Value, StatusCode) { pub async fn tasks(&self) -> (Value, StatusCode) {
self.service.get("/tasks").await self.service.get("/tasks").await
} }
pub async fn get_dump_status(&self, uid: &str) -> (Value, StatusCode) {
self.service.get(format!("/dumps/{}/status", uid)).await
}
} }
pub fn default_settings(dir: impl AsRef<Path>) -> Opt { pub fn default_settings(dir: impl AsRef<Path>) -> Opt {

View File

@ -0,0 +1,22 @@
#![allow(dead_code)]
mod common;
use crate::common::Server;
use serde_json::json;
#[actix_rt::test]
async fn get_unexisting_dump_status() {
let server = Server::new().await;
let (response, code) = server.get_dump_status("foobar").await;
assert_eq!(code, 404);
let expected_response = json!({
"message": "Dump `foobar` not found.",
"code": "dump_not_found",
"type": "invalid_request",
"link": "https://docs.meilisearch.com/errors#dump_not_found"
});
assert_eq!(response, expected_response);
}

View File

@ -59,10 +59,7 @@ impl ErrorCode for IndexControllerError {
IndexControllerError::DocumentFormatError(e) => e.error_code(), IndexControllerError::DocumentFormatError(e) => e.error_code(),
IndexControllerError::MissingPayload(_) => Code::MissingPayload, IndexControllerError::MissingPayload(_) => Code::MissingPayload,
IndexControllerError::PayloadTooLarge => Code::PayloadTooLarge, IndexControllerError::PayloadTooLarge => Code::PayloadTooLarge,
IndexControllerError::DumpError(DumpActorError::DumpAlreadyRunning) => { IndexControllerError::DumpError(e) => e.error_code(),
Code::DumpAlreadyInProgress
}
IndexControllerError::DumpError(_) => Code::DumpProcessFailed,
} }
} }
} }