diff --git a/benchmarks/scripts/compare.sh b/benchmarks/scripts/compare.sh index 067772bec..506c94015 100755 --- a/benchmarks/scripts/compare.sh +++ b/benchmarks/scripts/compare.sh @@ -11,9 +11,9 @@ # Checking that critcmp is installed command -v critcmp > /dev/null 2>&1 if [[ "$?" -ne 0 ]]; then - echo 'You must install critcmp to make this script working.' - echo '$ cargo install critcmp' + echo 'You must install critcmp to make this script work.' echo 'See: https://github.com/BurntSushi/critcmp' + echo ' $ cargo install critcmp' exit 1 fi @@ -21,38 +21,30 @@ if [[ $# -ne 2 ]] then echo 'Need 2 arguments.' echo 'Usage: ' - echo ' $ ./compare.sh file_to_download1 file_to_download2' + echo ' $ ./compare.sh old new' echo 'Ex:' echo ' $ ./compare.sh songs_main_09a4321.json songs_geosearch_24ec456.json' exit 1 fi -file1="$1" -file2="$2" +old_file="$1" +new_file="$2" s3_url='https://milli-benchmarks.fra1.digitaloceanspaces.com/critcmp_results' -file1_s3_url="$s3_url/$file1" -file2_s3_url="$s3_url/$file2" -file1_local_path="/tmp/$file1" -file2_local_path="/tmp/$file2" -if [[ ! -f "$file1_local_path" ]]; then - curl "$file1_s3_url" -O "$file1_local_path" - if [[ "$?" -ne 0 ]]; then - echo 'curl command failed.' - exit 1 +for file in $old_file $new_file +do + file_s3_url="$s3_url/$file" + file_local_path="/tmp/$file" + + if [[ ! -f $file_local_path ]]; then + curl $file_s3_url --output $file_local_path --silent + if [[ "$?" -ne 0 ]]; then + echo 'curl command failed.' + exit 1 + fi fi -else - echo "$file1 already present in /tmp, no need to download." -fi +done -if [[ ! -f "$file2_local_path" ]]; then - curl "$file2_s3_url" -O "$file2_local_path" - if [[ "$?" -ne 0 ]]; then - echo 'curl command failed.' - exit 1 - fi -else - echo "$file2 already present in /tmp, no need to download." -fi - -critcmp --color always "$file1_local_path" "$file2_local_path" +# Print the diff changes between the old and new benchmarks +# by only displaying the lines that have a diff of more than 5%. +critcmp --threshold 5 "/tmp/$old_file" "/tmp/$new_file"