snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-30 00:55:00 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix typos

Browse Source
This commit is contained in:
Irevoire 2021-11-09 16:40:05 +01:00
parent 99197387af
commit 73df873f44
No known key found for this signature in database
GPG Key ID: 7A6A970C96104F1B
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
filter-parser/README.md
View File

@ -33,5 +33,4 @@ cargo fuzz run parse -- -max_len=500
## What to do if you find a bug in the parser ## What to do if you find a bug in the parser
- Write a test at the end of the [`lib.rs`](./src/lib.rs) to ensure it never happens again. - Write a test at the end of the [`lib.rs`](./src/lib.rs) to ensure it never happens again.
- Add a file in [the corpus directory](./fuzz/corpus/parse/) with your filter to help the fuzzer finding new bug. Since this directory is going to be heavily polluted by the execution of the fuzzer it's in the gitignore and you'll need to force push your new test. - Add a file in [the corpus directory](./fuzz/corpus/parse/) with your filter to help the fuzzer find new bugs. Since this directory is going to be heavily polluted by the execution of the fuzzer it's in the gitignore and you'll need to force push your new test.
Since this directory is going to be heavily polluted by the execution of the fuzzer it's in the gitignore and you'll need to force add your new test.

6
filter-parser/src/lib.rs
View File

@ -141,7 +141,7 @@ impl<'a> FilterCondition<'a> {
} }
} }
/// remove OPTIONAL whitespaces before AND after the the provided parser. /// remove OPTIONAL whitespaces before AND after the provided parser.
fn ws<'a, O>(inner: impl FnMut(Span<'a>) -> IResult<O>) -> impl FnMut(Span<'a>) -> IResult<O> { fn ws<'a, O>(inner: impl FnMut(Span<'a>) -> IResult<O>) -> impl FnMut(Span<'a>) -> IResult<O> {
delimited(multispace0, inner, multispace0) delimited(multispace0, inner, multispace0)
} }
@ -184,7 +184,7 @@ fn parse_geo_radius(input: Span) -> IResult<FilterCondition> {
// we want to forbid space BEFORE the _geoRadius but not after // we want to forbid space BEFORE the _geoRadius but not after
let parsed = preceded( let parsed = preceded(
tuple((multispace0, tag("_geoRadius"))), tuple((multispace0, tag("_geoRadius"))),
// if we were able to parse `_geoRadius` and can't parse the rest of the input we returns a failure // if we were able to parse `_geoRadius` and can't parse the rest of the input we return a failure
cut(delimited(char('('), separated_list1(tag(","), ws(recognize_float)), char(')'))), cut(delimited(char('('), separated_list1(tag(","), ws(recognize_float)), char(')'))),
)(input) )(input)
.map_err(|e| e.map(|_| Error::new_from_kind(input, ErrorKind::Geo))); .map_err(|e| e.map(|_| Error::new_from_kind(input, ErrorKind::Geo)));
@ -212,7 +212,7 @@ fn parse_geo_point(input: Span) -> IResult<FilterCondition> {
cut(delimited(char('('), separated_list1(tag(","), ws(|c| recognize_float(c))), char(')'))), cut(delimited(char('('), separated_list1(tag(","), ws(|c| recognize_float(c))), char(')'))),
))(input) ))(input)
.map_err(|e| e.map(|_| Error::new_from_kind(input, ErrorKind::ReservedGeo("_geoPoint"))))?; .map_err(|e| e.map(|_| Error::new_from_kind(input, ErrorKind::ReservedGeo("_geoPoint"))))?;
// if we succeeded we still returns a Failure because geoPoints are not allowed // if we succeeded we still return a `Failure` because geoPoints are not allowed
Err(nom::Err::Failure(Error::new_from_kind(input, ErrorKind::ReservedGeo("_geoPoint")))) Err(nom::Err::Failure(Error::new_from_kind(input, ErrorKind::ReservedGeo("_geoPoint"))))
} }