snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-26 20:15:07 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fix bug in position rr

Browse Source
This commit is contained in:
Loïc Lecrenier 2023-05-01 11:30:51 +02:00
parent 79001b9c97
commit 608ceea440
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
milli/src/search/new/ranking_rule_graph/position/mod.rs
View File

@ -74,22 +74,24 @@ impl RankingRuleGraphTrait for PositionGraph {
let mut edges = vec![]; let mut edges = vec![];
for position in all_positions { for position in all_positions {
let sum_positions = { let cost = {
let mut cost = 0; let mut cost = 0;
for i in 0..term.term_ids.len() { for i in 0..term.term_ids.len() {
// This is actually not fully correct and slightly penalises ngrams unfairly. // This is actually not fully correct and slightly penalises ngrams unfairly.
// Because if two words are in the same bucketed position (e.g. 32) and consecutive, // Because if two words are in the same bucketed position (e.g. 32) and consecutive,
// then their position cost will be 32+32=64, but an ngram of these two words at the // then their position cost will be 32+32=64, but an ngram of these two words at the
// same position will have a cost of 32+32+1=65 // same position will have a cost of 32+32+1=65
cost += position as u32 + i as u32; cost += cost_from_position(position as u32 + i as u32);
} }
cost cost
}; };
// TODO: We can improve performances and relevancy by storing // TODO: We can improve performances and relevancy by storing
// the term subsets associated to each position fetched. // the term subsets associated to each position fetched.
//
// TODO: group conditions by their cost
edges.push(( edges.push((
cost_from_sum_positions(sum_positions), cost,
conditions_interner.insert(PositionCondition { conditions_interner.insert(PositionCondition {
term: term.clone(), // TODO remove this ugly clone term: term.clone(), // TODO remove this ugly clone
position, position,
@ -101,7 +103,7 @@ impl RankingRuleGraphTrait for PositionGraph {
} }
} }
fn cost_from_sum_positions(sum_positions: u32) -> u32 { fn cost_from_position(sum_positions: u32) -> u32 {
match sum_positions { match sum_positions {
0 | 1 | 2 | 3 => sum_positions, 0 | 1 | 2 | 3 => sum_positions,
4 | 5 => 4, 4 | 5 => 4,