From 5727e003743b8d4e1ca511c2352c2a7733da3ec6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Renault?= Date: Thu, 21 Nov 2024 15:58:51 +0100 Subject: [PATCH] Remove useless geo skipped --- .../src/update/new/extract/searchable/extract_word_docids.rs | 2 +- .../extract/searchable/extract_word_pair_proximity_docids.rs | 2 +- crates/milli/src/update/new/indexer/mod.rs | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/crates/milli/src/update/new/extract/searchable/extract_word_docids.rs b/crates/milli/src/update/new/extract/searchable/extract_word_docids.rs index eef9b322a..05e2374dc 100644 --- a/crates/milli/src/update/new/extract/searchable/extract_word_docids.rs +++ b/crates/milli/src/update/new/extract/searchable/extract_word_docids.rs @@ -415,6 +415,6 @@ impl WordDocidsExtractors { } fn attributes_to_skip<'a>(_rtxn: &'a RoTxn, _index: &'a Index) -> Result> { - Ok(vec!["_geo"]) + Ok(Vec::new()) } } diff --git a/crates/milli/src/update/new/extract/searchable/extract_word_pair_proximity_docids.rs b/crates/milli/src/update/new/extract/searchable/extract_word_pair_proximity_docids.rs index 945f0b8b3..dcd9e3a78 100644 --- a/crates/milli/src/update/new/extract/searchable/extract_word_pair_proximity_docids.rs +++ b/crates/milli/src/update/new/extract/searchable/extract_word_pair_proximity_docids.rs @@ -25,7 +25,7 @@ impl SearchableExtractor for WordPairProximityDocidsExtractor { } fn attributes_to_skip<'a>(_rtxn: &'a RoTxn, _index: &'a Index) -> Result> { - Ok(vec!["_geo"]) + Ok(Vec::new()) } // This method is reimplemented to count the number of words in the document in each field diff --git a/crates/milli/src/update/new/indexer/mod.rs b/crates/milli/src/update/new/indexer/mod.rs index c1d34d040..01ac26503 100644 --- a/crates/milli/src/update/new/indexer/mod.rs +++ b/crates/milli/src/update/new/indexer/mod.rs @@ -103,7 +103,6 @@ where // prevent moving the field_distribution and document_ids in the inner closure... let field_distribution = &mut field_distribution; let document_ids = &mut document_ids; - // TODO manage the errors correctly let extractor_handle = Builder::new().name(S("indexer-extractors")).spawn_scoped(s, move || { let span = tracing::trace_span!(target: "indexing::documents", parent: &indexer_span, "extract"); let _entered = span.enter();