feat(search, criteria): introduce a percentage threshold to the asc/desc

This commit is contained in:
Alexey Shekhirin 2021-03-29 19:07:22 +03:00
parent 9ad8b74111
commit 522e79f2e0

View File

@ -19,6 +19,10 @@ use crate::search::WordDerivationsCache;
use crate::{FieldsIdsMap, FieldId, Index}; use crate::{FieldsIdsMap, FieldId, Index};
use super::{Criterion, CriterionResult}; use super::{Criterion, CriterionResult};
/// If the number of candidates is lower or equal to the specified % of total number of documents,
/// use simple sort. Otherwise, use facet database.
const CANDIDATES_THRESHOLD: f64 = 0.1;
pub struct AscDesc<'t> { pub struct AscDesc<'t> {
index: &'t Index, index: &'t Index,
rtxn: &'t heed::RoTxn<'t>, rtxn: &'t heed::RoTxn<'t>,
@ -237,7 +241,7 @@ fn field_id_facet_type(
/// Returns an iterator over groups of the given candidates in ascending or descending order. /// Returns an iterator over groups of the given candidates in ascending or descending order.
/// ///
/// It will either use an iterative or a recusrsive method on the whole facet database depending /// It will either use an iterative or a recursive method on the whole facet database depending
/// on the number of candidates to rank. /// on the number of candidates to rank.
fn facet_ordered<'t>( fn facet_ordered<'t>(
index: &'t Index, index: &'t Index,
@ -248,9 +252,11 @@ fn facet_ordered<'t>(
candidates: RoaringBitmap, candidates: RoaringBitmap,
) -> anyhow::Result<Box<dyn Iterator<Item = heed::Result<RoaringBitmap>> + 't>> ) -> anyhow::Result<Box<dyn Iterator<Item = heed::Result<RoaringBitmap>> + 't>>
{ {
let number_of_documents = index.number_of_documents(&rtxn)? as f64;
match facet_type { match facet_type {
FacetType::Float => { FacetType::Float => {
if candidates.len() <= 1000 { if candidates.len() / number_of_documents * 100 <= CANDIDATES_THRESHOLD {
let iter = iterative_facet_ordered_iter::<FieldDocIdFacetF64Codec, f64, OrderedFloat<f64>>( let iter = iterative_facet_ordered_iter::<FieldDocIdFacetF64Codec, f64, OrderedFloat<f64>>(
index, rtxn, field_id, ascending, candidates, index, rtxn, field_id, ascending, candidates,
)?; )?;
@ -266,7 +272,7 @@ fn facet_ordered<'t>(
} }
}, },
FacetType::Integer => { FacetType::Integer => {
if candidates.len() <= 1000 { if candidates.len() / number_of_documents * 100 <= CANDIDATES_THRESHOLD {
let iter = iterative_facet_ordered_iter::<FieldDocIdFacetI64Codec, i64, i64>( let iter = iterative_facet_ordered_iter::<FieldDocIdFacetI64Codec, i64, i64>(
index, rtxn, field_id, ascending, candidates, index, rtxn, field_id, ascending, candidates,
)?; )?;