snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-25 11:35:05 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Do not check before pushing in bitmaps

Browse Source
This commit is contained in:
Clément Renault 2024-09-24 09:42:21 +02:00
parent ff931edb55
commit 4ce5d3d66d
No known key found for this signature in database
GPG Key ID: F250A4C4E3AE5F5F
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
milli/src/update/new/extract/cache.rs
View File

@ -198,30 +198,29 @@ impl DelAddRoaringBitmap {
#[derive(Debug, Clone, Default)] #[derive(Debug, Clone, Default)]
struct PushOptimizedBitmap { struct PushOptimizedBitmap {
max: Option<u32>,
bitmap: RoaringBitmap, bitmap: RoaringBitmap,
} }
impl PushOptimizedBitmap { impl PushOptimizedBitmap {
#[inline]
fn from_bitmap(bitmap: RoaringBitmap) -> PushOptimizedBitmap { fn from_bitmap(bitmap: RoaringBitmap) -> PushOptimizedBitmap {
PushOptimizedBitmap { max: bitmap.max(), bitmap } PushOptimizedBitmap { bitmap }
} }
#[inline]
fn from_single(single: u32) -> PushOptimizedBitmap { fn from_single(single: u32) -> PushOptimizedBitmap {
PushOptimizedBitmap { max: Some(single), bitmap: RoaringBitmap::from([single]) } PushOptimizedBitmap { bitmap: RoaringBitmap::from([single]) }
} }
#[inline]
fn insert(&mut self, n: u32) { fn insert(&mut self, n: u32) {
if self.max.map_or(true, |max| n > max) { if !self.bitmap.push(n) {
self.max = Some(n);
self.bitmap.push(n);
} else {
self.bitmap.insert(n); self.bitmap.insert(n);
} }
} }
#[inline]
fn union_with_bitmap(&mut self, bitmap: RoaringBitmap) { fn union_with_bitmap(&mut self, bitmap: RoaringBitmap) {
self.bitmap |= bitmap; self.bitmap |= bitmap;
self.max = self.bitmap.max();
} }
} }