From 3d244451dfd5903694f0c59ed34f334cf91fdf96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Renault?= <clement@meilisearch.com>
Date: Wed, 25 Sep 2024 16:14:13 +0200
Subject: [PATCH] Reduce the lru key size from 8 to 12 bytes

---
 milli/src/update/new/extract/cache.rs |  2 +-
 milli/src/update/new/extract/lru.rs   | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/milli/src/update/new/extract/cache.rs b/milli/src/update/new/extract/cache.rs
index 1e95d9cda..1b7a58472 100644
--- a/milli/src/update/new/extract/cache.rs
+++ b/milli/src/update/new/extract/cache.rs
@@ -9,7 +9,7 @@ use super::lru::Lru;
 use crate::update::del_add::{DelAdd, KvWriterDelAdd};
 use crate::CboRoaringBitmapCodec;
 
-const KEY_SIZE: usize = 8;
+const KEY_SIZE: usize = 12;
 
 #[derive(Debug)]
 pub struct CboCachedSorter<MF> {
diff --git a/milli/src/update/new/extract/lru.rs b/milli/src/update/new/extract/lru.rs
index 7346c38af..3eca47cb2 100644
--- a/milli/src/update/new/extract/lru.rs
+++ b/milli/src/update/new/extract/lru.rs
@@ -121,8 +121,8 @@ struct FixedSizeListNode<T> {
 #[derive(Debug)]
 struct FixedSizeList<T> {
     nodes: Box<[Option<FixedSizeListNode<T>>]>,
-    /// The first `None` in the nodes.
-    next_free: usize,
+    /// Also corresponds to the first `None` in the nodes.
+    length: usize,
     // TODO Also, we probably do not need one of the front and back cursors.
     front: usize,
     back: usize,
@@ -132,7 +132,7 @@ impl<T> FixedSizeList<T> {
     fn new(capacity: usize) -> Self {
         Self {
             nodes: repeat_with(|| None).take(capacity).collect::<Vec<_>>().into_boxed_slice(),
-            next_free: 0,
+            length: 0,
             front: usize::MAX,
             back: usize::MAX,
         }
@@ -145,7 +145,7 @@ impl<T> FixedSizeList<T> {
 
     #[inline]
     fn len(&self) -> usize {
-        self.next_free
+        self.length
     }
 
     #[inline]
@@ -168,8 +168,8 @@ impl<T> FixedSizeList<T> {
         if self.is_full() {
             None
         } else {
-            let current_free = self.next_free;
-            self.next_free += 1;
+            let current_free = self.length;
+            self.length += 1;
             Some(current_free)
         }
     }