From 3bac22fd87b7c5d384eb2395b087c7bc61e8f0fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Renault?= Date: Wed, 10 Jul 2024 10:12:35 +0200 Subject: [PATCH] We do not do intersections with the universe when it is related to cache --- .../search/new/ranking_rule_graph/proximity/compute_docids.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/milli/src/search/new/ranking_rule_graph/proximity/compute_docids.rs b/milli/src/search/new/ranking_rule_graph/proximity/compute_docids.rs index 68b934e20..39dbef46d 100644 --- a/milli/src/search/new/ranking_rule_graph/proximity/compute_docids.rs +++ b/milli/src/search/new/ranking_rule_graph/proximity/compute_docids.rs @@ -136,7 +136,6 @@ fn compute_prefix_edges( } } - // TODO check that the fact that the universe always changes is not an issue, e.g. caching stuff. if let Some(new_docids) = ctx.get_db_word_prefix_pair_proximity_docids( Some(&universe), left_word, @@ -152,7 +151,6 @@ fn compute_prefix_edges( // No swapping when computing the proximity between a phrase and a word if left_phrase.is_none() { - // TODO check that the fact that the universe always changes is not an issue, e.g. caching stuff. if let Some(new_docids) = ctx.get_db_prefix_word_pair_proximity_docids( Some(&universe), right_prefix, @@ -190,7 +188,6 @@ fn compute_non_prefix_edges( } } - // TODO check that it is not an issue to alterate the universe if let Some(new_docids) = ctx.get_db_word_pair_proximity_docids(Some(&universe), word1, word2, forward_proximity)? {