snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-29 16:45:30 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

"[]" is deserialized as 0 embedding rather than 1 embedding of dim 0

Browse Source
This commit is contained in:
Louis Dureuil 2024-05-22 12:25:21 +02:00
parent 16037e2169
commit 3412e7fbcf
No known key found for this signature in database
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
milli/src/vector/parsed_vectors.rs
View File

@ -136,19 +136,19 @@ fn to_vector_map(
#[serde(transparent)] #[serde(transparent)]
pub struct VectorOrArrayOfVectors { pub struct VectorOrArrayOfVectors {
#[serde(with = "either::serde_untagged_optional")] #[serde(with = "either::serde_untagged_optional")]
inner: Option<either::Either<Embedding, Vec<Embedding>>>, inner: Option<either::Either<Vec<Embedding>, Embedding>>,
} }
impl VectorOrArrayOfVectors { impl VectorOrArrayOfVectors {
pub fn into_array_of_vectors(self) -> Option<Vec<Embedding>> { pub fn into_array_of_vectors(self) -> Option<Vec<Embedding>> {
match self.inner? { match self.inner? {
either::Either::Left(vector) => Some(vec![vector]), either::Either::Left(vectors) => Some(vectors),
either::Either::Right(vectors) => Some(vectors), either::Either::Right(vector) => Some(vec![vector]),
} }
} }
pub fn from_array_of_vectors(array_of_vec: Vec<Embedding>) -> Self { pub fn from_array_of_vectors(array_of_vec: Vec<Embedding>) -> Self {
Self { inner: Some(either::Either::Right(array_of_vec)) } Self { inner: Some(either::Either::Left(array_of_vec)) }
} }
} }
@ -167,12 +167,7 @@ mod test {
serde_json::from_str("[[0.1, 0.2], [0.3, 0.4]]").unwrap(); serde_json::from_str("[[0.1, 0.2], [0.3, 0.4]]").unwrap();
insta::assert_json_snapshot!(null.into_array_of_vectors(), @"null"); insta::assert_json_snapshot!(null.into_array_of_vectors(), @"null");
// 👇 is the the intended behavior? would rather expect [] here, but changing that is a breaking change... insta::assert_json_snapshot!(empty.into_array_of_vectors(), @"[]");
insta::assert_json_snapshot!(empty.into_array_of_vectors(), @r###"
[
[]
]
"###);
insta::assert_json_snapshot!(one.into_array_of_vectors(), @r###" insta::assert_json_snapshot!(one.into_array_of_vectors(), @r###"
[ [
[ [