snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-23 10:37:41 +08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Fixed issue where the default revision is always the one we picked for the default model

Browse Source
This commit is contained in:
Louis Dureuil 2023-12-20 10:17:49 +01:00
parent fb9db1eba6
commit 333ce12eb2
No known key found for this signature in database
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
milli/src/vector/settings.rs
View File

@ -228,6 +228,12 @@ impl From<HfEmbedderSettings> for crate::vector::hf::EmbedderOptions {
let mut this = Self::default(); let mut this = Self::default();
if let Some(model) = model.set() { if let Some(model) = model.set() {
this.model = model; this.model = model;
// Reset the revision if we are setting the model.
// This allows the following:
// "huggingFace": {} -> default model with default revision
// "huggingFace": { "model": "name-of-the-default-model" } -> default model without a revision
// "huggingFace": { "model": "some-other-model" } -> most importantly, other model without a revision
this.revision = None;
} }
if let Some(revision) = revision.set() { if let Some(revision) = revision.set() {
this.revision = Some(revision); this.revision = Some(revision);