snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-29 08:35:15 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Remove key from index_tasks database when the value is empty

Browse Source
This commit is contained in:
Loïc Lecrenier 2022-10-20 09:56:43 +02:00 committed by Clément Renault
parent 169f386418
commit 28bd8b6c6b
No known key found for this signature in database
GPG Key ID: 92ADA4E935E71FA4
3 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
index-scheduler/src/snapshots/lib.rs/task_deletion_delete_same_task_twice/task_deletion_processed.snap
View File

@ -19,7 +19,6 @@ succeeded [2,3,]
"taskDeletion" [2,3,] "taskDeletion" [2,3,]
---------------------------------------------------------------------- ----------------------------------------------------------------------
### Index Tasks: ### Index Tasks:
catto []
doggo [1,] doggo [1,]
---------------------------------------------------------------------- ----------------------------------------------------------------------
### Index Mapper: ### Index Mapper:

1
index-scheduler/src/snapshots/lib.rs/task_deletion_deleteable/task_deletion_processed.snap
View File

@ -18,7 +18,6 @@ succeeded [2,]
"taskDeletion" [2,] "taskDeletion" [2,]
---------------------------------------------------------------------- ----------------------------------------------------------------------
### Index Tasks: ### Index Tasks:
catto []
doggo [1,] doggo [1,]
---------------------------------------------------------------------- ----------------------------------------------------------------------
### Index Mapper: ### Index Mapper:

15
index-scheduler/src/utils.rs
View File

@ -112,15 +112,6 @@ impl IndexScheduler {
Ok(self.index_tasks.get(rtxn, index)?.unwrap_or_default()) Ok(self.index_tasks.get(rtxn, index)?.unwrap_or_default())
} }
pub(crate) fn put_index(
&self,
wtxn: &mut RwTxn,
index: &str,
bitmap: &RoaringBitmap,
) -> Result<()> {
Ok(self.index_tasks.put(wtxn, index, bitmap)?)
}
pub(crate) fn update_index( pub(crate) fn update_index(
&self, &self,
wtxn: &mut RwTxn, wtxn: &mut RwTxn,
@ -129,7 +120,11 @@ impl IndexScheduler {
) -> Result<()> { ) -> Result<()> {
let mut tasks = self.index_tasks(wtxn, index)?; let mut tasks = self.index_tasks(wtxn, index)?;
f(&mut tasks); f(&mut tasks);
self.put_index(wtxn, index, &tasks)?; if tasks.is_empty() {
self.index_tasks.delete(wtxn, index)?;
} else {
self.index_tasks.put(wtxn, index, &tasks)?;
}
Ok(()) Ok(())
} }