From 1991bd03daf30d29b612ff613a463ad94b98d6f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Renault?= Date: Tue, 11 Jun 2024 17:02:39 -0400 Subject: [PATCH] Distinct at search erases the distinct in the settings --- milli/src/search/new/mod.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/milli/src/search/new/mod.rs b/milli/src/search/new/mod.rs index 257f81539..5921e27eb 100644 --- a/milli/src/search/new/mod.rs +++ b/milli/src/search/new/mod.rs @@ -752,8 +752,6 @@ pub fn execute_search( // The candidates is the universe unless the exhaustive number of hits // is requested and a distinct attribute is set. if exhaustive_number_hits { - // TODO Should the distinct search parameter replace the distinct setting? - // Or should we return an error if the distinct search param is set at the same time as the setting is set? let distinct_field = match distinct.as_deref() { Some(distinct) => Some(distinct), None => ctx.index.distinct_field(ctx.txn)?,