From b2d25c07d79ba1e93692c1daada1359a46372eff Mon Sep 17 00:00:00 2001 From: curquiza Date: Mon, 30 Jan 2023 14:31:36 +0100 Subject: [PATCH 1/4] Add guide to create a proto --- CONTRIBUTING.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4b849756b..ec268e2de 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -99,6 +99,28 @@ _[Read more about this](https://github.com/meilisearch/integration-guides/blob/m The full Meilisearch release process is described in [this guide](https://github.com/meilisearch/engine-team/blob/main/resources/meilisearch-release.md). Please follow it carefully before doing any release. +### How to publish a prototype + +Depending on the developed feature, you might need to provide a prototyped version of Meilisearch to make it easier to test by the users. + +The prototype name must follow this convention: `prototype-X-Y` where +- `X` is the feature name +- `Y` is the version of the prototype, starting from `0`. + +Example: `prototype-auto-resize-0`. + +Steps to create a prototype: + +1. In your terminal, go to the last commit of your branch (the one you want to provide as a prototype). +2. Create a tag following the convention: `git tag prototype-X-Y` +3. Push the tag: `git push origin prototype-X-Y` +4. Check the [Docker CI](https://github.com/meilisearch/meilisearch/actions/workflows/publish-docker-images.yml) is now running. + +⚙️ Once the CI has finished to run (~1h30), a Docker image named `prototype-X-Y` will be available on [DockerHub](https://hub.docker.com/repository/docker/getmeili/meilisearch/general). People can use it with the following command: `docker run -p 7700:7700 getmeili/meilisearch:prototype-X-Y`. +However, no binaries will be created. If the users do not use Docker, they can go to the `prototype-X-Y` tag in the Meilisearch repository and compile from the source code. + +⚠️ When sharing a prototype with users, prevent them from using it in production. Prototypes are only for test purposes. + ### Release assets For each release, the following assets are created: From 3505ee47f84cfd069e85835cda83ad93b419ec7d Mon Sep 17 00:00:00 2001 From: curquiza Date: Mon, 30 Jan 2023 14:33:09 +0100 Subject: [PATCH 2/4] Add volume to docker command --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ec268e2de..50d8d13bc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -116,7 +116,7 @@ Steps to create a prototype: 3. Push the tag: `git push origin prototype-X-Y` 4. Check the [Docker CI](https://github.com/meilisearch/meilisearch/actions/workflows/publish-docker-images.yml) is now running. -⚙️ Once the CI has finished to run (~1h30), a Docker image named `prototype-X-Y` will be available on [DockerHub](https://hub.docker.com/repository/docker/getmeili/meilisearch/general). People can use it with the following command: `docker run -p 7700:7700 getmeili/meilisearch:prototype-X-Y`. +⚙️ Once the CI has finished to run (~1h30), a Docker image named `prototype-X-Y` will be available on [DockerHub](https://hub.docker.com/repository/docker/getmeili/meilisearch/general). People can use it with the following command: `docker run -p 7700:7700 -v $(pwd)/meili_data:/meili_data getmeili/meilisearch:prototype-X-Y`. More information about [how to run Meilisearch with Docher](https://docs.meilisearch.com/learn/cookbooks/docker.html#download-meilisearch-with-docker). However, no binaries will be created. If the users do not use Docker, they can go to the `prototype-X-Y` tag in the Meilisearch repository and compile from the source code. ⚠️ When sharing a prototype with users, prevent them from using it in production. Prototypes are only for test purposes. From 982dd760429d41719f76e98c9c3fcdace080b07e Mon Sep 17 00:00:00 2001 From: curquiza Date: Mon, 30 Jan 2023 14:35:14 +0100 Subject: [PATCH 3/4] Improve readability --- CONTRIBUTING.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 50d8d13bc..2467f3aa8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -116,8 +116,10 @@ Steps to create a prototype: 3. Push the tag: `git push origin prototype-X-Y` 4. Check the [Docker CI](https://github.com/meilisearch/meilisearch/actions/workflows/publish-docker-images.yml) is now running. -⚙️ Once the CI has finished to run (~1h30), a Docker image named `prototype-X-Y` will be available on [DockerHub](https://hub.docker.com/repository/docker/getmeili/meilisearch/general). People can use it with the following command: `docker run -p 7700:7700 -v $(pwd)/meili_data:/meili_data getmeili/meilisearch:prototype-X-Y`. More information about [how to run Meilisearch with Docher](https://docs.meilisearch.com/learn/cookbooks/docker.html#download-meilisearch-with-docker). -However, no binaries will be created. If the users do not use Docker, they can go to the `prototype-X-Y` tag in the Meilisearch repository and compile from the source code. +🐳 Once the CI has finished to run (~1h30), a Docker image named `prototype-X-Y` will be available on [DockerHub](https://hub.docker.com/repository/docker/getmeili/meilisearch/general). People can use it with the following command: `docker run -p 7700:7700 -v $(pwd)/meili_data:/meili_data getmeili/meilisearch:prototype-X-Y`.
+More information about [how to run Meilisearch with Docker](https://docs.meilisearch.com/learn/cookbooks/docker.html#download-meilisearch-with-docker). + +⚙️ However, no binaries will be created. If the users do not use Docker, they can go to the `prototype-X-Y` tag in the Meilisearch repository and compile from the source code. ⚠️ When sharing a prototype with users, prevent them from using it in production. Prototypes are only for test purposes. From 2ba4629938588fbc2d5e4fdb3d237773e33e8f72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9mentine=20Urquizar=20-=20curqui?= Date: Mon, 30 Jan 2023 15:56:30 +0100 Subject: [PATCH 4/4] Update CONTRIBUTING.md Co-authored-by: Many the fish --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2467f3aa8..158629ffc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -104,7 +104,7 @@ The full Meilisearch release process is described in [this guide](https://github Depending on the developed feature, you might need to provide a prototyped version of Meilisearch to make it easier to test by the users. The prototype name must follow this convention: `prototype-X-Y` where -- `X` is the feature name +- `X` is the feature name formatted in `kebab-case` - `Y` is the version of the prototype, starting from `0`. Example: `prototype-auto-resize-0`.