snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2024-11-26 12:05:05 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Apply review suggestions and stop using rtxn.commit

Browse Source
This commit is contained in:
Loïc Lecrenier 2022-10-19 07:34:10 +02:00 committed by Clément Renault
parent 17cd2a4aa0
commit 11fee30f47
No known key found for this signature in database
GPG Key ID: 92ADA4E935E71FA4
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
index-scheduler/src/batch.rs
View File

@ -686,8 +686,7 @@ impl IndexScheduler {
| IndexOperation::DocumentClear { ref index_uid, .. } => { | IndexOperation::DocumentClear { ref index_uid, .. } => {
// only get the index, don't create it // only get the index, don't create it
let rtxn = self.env.read_txn()?; let rtxn = self.env.read_txn()?;
let r = self.index_mapper.index(&rtxn, index_uid)?; self.index_mapper.index(&rtxn, index_uid)?
r
} }
IndexOperation::DocumentImport { ref index_uid, allow_index_creation, .. } IndexOperation::DocumentImport { ref index_uid, allow_index_creation, .. }
| IndexOperation::Settings { ref index_uid, allow_index_creation, .. } | IndexOperation::Settings { ref index_uid, allow_index_creation, .. }
@ -701,8 +700,7 @@ impl IndexScheduler {
index index
} else { } else {
let rtxn = self.env.read_txn()?; let rtxn = self.env.read_txn()?;
let r = self.index_mapper.index(&rtxn, index_uid)?; self.index_mapper.index(&rtxn, index_uid)?
r
} }
} }
}; };

2
index-scheduler/src/lib.rs
View File

@ -718,7 +718,7 @@ impl IndexScheduler {
Some(batch) => batch, Some(batch) => batch,
None => return Ok(0), None => return Ok(0),
}; };
drop(rtxn); //rtxn.commit()?; drop(rtxn);
// 1. store the starting date with the bitmap of processing tasks. // 1. store the starting date with the bitmap of processing tasks.
let mut ids = batch.ids(); let mut ids = batch.ids();

2
index-scheduler/src/snapshot.rs
View File

@ -80,8 +80,6 @@ pub fn snapshot_index_scheduler(scheduler: &IndexScheduler) -> String {
snap.push_str(&snapshot_file_store(file_store)); snap.push_str(&snapshot_file_store(file_store));
snap.push_str("\n----------------------------------------------------------------------\n"); snap.push_str("\n----------------------------------------------------------------------\n");
rtxn.commit().unwrap();
snap snap
} }