From 8b14090927d2ee6c0958f29f98cd52b996599c83 Mon Sep 17 00:00:00 2001
From: ad hoc <postma.marin@protonmail.com>
Date: Mon, 18 Apr 2022 22:48:22 +0200
Subject: [PATCH] fix min-word-len-for-typo not reset properly

---
 milli/src/update/settings.rs | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/milli/src/update/settings.rs b/milli/src/update/settings.rs
index 7dd37ccc2..ff59249b7 100644
--- a/milli/src/update/settings.rs
+++ b/milli/src/update/settings.rs
@@ -10,6 +10,7 @@ use super::index_documents::{IndexDocumentsConfig, Transform};
 use super::IndexerConfig;
 use crate::criterion::Criterion;
 use crate::error::UserError;
+use crate::index::{DEFAULT_MIN_WORD_LEN_ONE_TYPO, DEFAULT_MIN_WORD_LEN_TWO_TYPOS};
 use crate::update::index_documents::IndexDocumentsMethod;
 use crate::update::{ClearDocuments, IndexDocuments, UpdateIndexingStep};
 use crate::{FieldsIdsMap, Index, Result};
@@ -46,6 +47,14 @@ impl<T> Setting<T> {
     pub const fn is_not_set(&self) -> bool {
         matches!(self, Self::NotSet)
     }
+
+    /// If `Self` is `Reset`, then map self to `Set` with the provided `val`.
+    pub fn or_reset(self, val: T) -> Self {
+        match self {
+            Self::Reset => Self::Set(val),
+            otherwise => otherwise,
+        }
+    }
 }
 
 impl<T: Serialize> Serialize for Setting<T> {
@@ -535,7 +544,9 @@ impl<'a, 't, 'u, 'i> Settings<'a, 't, 'u, 'i> {
     }
 
     fn update_min_typo_word_len(&mut self) -> Result<()> {
-        match (self.min_word_len_one_typo, self.min_word_len_two_typos) {
+        let one = self.min_word_len_one_typo.or_reset(DEFAULT_MIN_WORD_LEN_ONE_TYPO);
+        let two = self.min_word_len_two_typos.or_reset(DEFAULT_MIN_WORD_LEN_TWO_TYPOS);
+        match (one, two) {
             (Setting::Set(one), Setting::Set(two)) => {
                 if one > two {
                     return Err(UserError::InvalidMinTypoWordLenSetting(one, two).into());
@@ -1422,6 +1433,20 @@ mod tests {
 
         assert_eq!(index.min_word_len_one_typo(&txn).unwrap(), 8);
         assert_eq!(index.min_word_len_two_typos(&txn).unwrap(), 8);
+
+        let mut txn = index.write_txn().unwrap();
+        let mut builder = Settings::new(&mut txn, &index, &config);
+
+        builder.reset_min_word_len_one_typo();
+        builder.reset_min_word_len_two_typos();
+        builder.execute(|_| ()).unwrap();
+
+        txn.commit().unwrap();
+
+        let txn = index.read_txn().unwrap();
+
+        assert_eq!(index.min_word_len_one_typo(&txn).unwrap(), DEFAULT_MIN_WORD_LEN_ONE_TYPO);
+        assert_eq!(index.min_word_len_two_typos(&txn).unwrap(), DEFAULT_MIN_WORD_LEN_TWO_TYPOS);
     }
 
     #[test]