From 01b27e40ad05ce18db5abd9b6f871aea14fbe48a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Renault?= Date: Tue, 19 Nov 2024 15:56:03 +0100 Subject: [PATCH] Fix a bit of the placeholder search tests --- crates/milli/src/update/index_documents/mod.rs | 4 +++- .../word_docids.snap | 5 ++--- .../initial/word_docids.snap | 17 +++++------------ 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/crates/milli/src/update/index_documents/mod.rs b/crates/milli/src/update/index_documents/mod.rs index 511ec2e22..8d038cf2a 100644 --- a/crates/milli/src/update/index_documents/mod.rs +++ b/crates/milli/src/update/index_documents/mod.rs @@ -2877,10 +2877,12 @@ mod tests { let mut wtxn = index.write_txn().unwrap(); delete_documents(&mut wtxn, &index, &["1_4", "1_70", "1_72"]); + wtxn.commit().unwrap(); + let rtxn = index.read_txn().unwrap(); // Placeholder search with filter let filter = Filter::from_str("label = sign").unwrap().unwrap(); - let results = index.search(&wtxn).filter(filter).execute().unwrap(); + let results = index.search(&rtxn).filter(filter).execute().unwrap(); assert!(results.documents_ids.is_empty()); db_snap!(index, word_docids); diff --git a/crates/milli/src/update/index_documents/snapshots/mod.rs/filtered_placeholder_search_should_not_return_deleted_documents/word_docids.snap b/crates/milli/src/update/index_documents/snapshots/mod.rs/filtered_placeholder_search_should_not_return_deleted_documents/word_docids.snap index 73503f098..97c8e0729 100644 --- a/crates/milli/src/update/index_documents/snapshots/mod.rs/filtered_placeholder_search_should_not_return_deleted_documents/word_docids.snap +++ b/crates/milli/src/update/index_documents/snapshots/mod.rs/filtered_placeholder_search_should_not_return_deleted_documents/word_docids.snap @@ -1,8 +1,8 @@ --- -source: milli/src/update/index_documents/mod.rs +source: crates/milli/src/update/index_documents/mod.rs --- 1 [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 21, ] -2 [21, ] +2.2 [21, ] 36 [3, ] 37 [4, ] 38 [5, ] @@ -35,4 +35,3 @@ letter [1, ] outdoor [4, ] painting [3, ] pattern [2, 3, 9, 10, 13, 14, 16, ] - diff --git a/crates/milli/src/update/index_documents/snapshots/mod.rs/simple_documents_replace/initial/word_docids.snap b/crates/milli/src/update/index_documents/snapshots/mod.rs/simple_documents_replace/initial/word_docids.snap index 6e7876726..89076a652 100644 --- a/crates/milli/src/update/index_documents/snapshots/mod.rs/simple_documents_replace/initial/word_docids.snap +++ b/crates/milli/src/update/index_documents/snapshots/mod.rs/simple_documents_replace/initial/word_docids.snap @@ -1,21 +1,15 @@ --- -source: milli/src/update/index_documents/mod.rs +source: crates/milli/src/update/index_documents/mod.rs --- -0 [1, ] 1 [2, ] -10 [1, ] -12 [0, ] +10.0 [1, ] 1344 [3, ] 2 [0, ] -23 [5, ] -25 [2, ] -3 [0, ] -35 [5, ] +25.99 [2, ] +3.5 [0, ] 4 [4, ] -42 [0, 5, ] +42 [5, ] 456 [1, ] -5 [0, ] -99 [2, ] adams [5, ] adventure [1, ] alice [2, ] @@ -54,4 +48,3 @@ the [3, 4, 5, ] to [5, ] tolkien [3, ] wonderland [2, ] -