Migrate to Biome for linting and formatting (#107)

2025-02-22 00:25:24 +08:00 · 2024-09-30 02:55:24 -04:00 · 2024-09-30 02:55:24 -04:00 · c11f8674f8
commit c11f8674f8
parent 023eb7875f
17 changed files with 331 additions and 5772 deletions
--- a/.eslintignore
+++ b/.eslintignore
@ -1,4 +0,0 @@
-dist/
-lib/
-node_modules/
-jest.config.js
--- a/.eslintrc.json
+++ b/.eslintrc.json
@ -1,61 +0,0 @@
-{
-  "plugins": ["jest", "@typescript-eslint"],
-  "extends": ["plugin:github/recommended"],
-  "parser": "@typescript-eslint/parser",
-  "parserOptions": {
-    "ecmaVersion": 9,
-    "sourceType": "module",
-    "project": "./tsconfig.json"
-  },
-  "rules": {
-    "no-shadow": "off",
-    "@typescript-eslint/no-shadow": ["error"],
-    "i18n-text/no-en": "off",
-    "eslint-comments/no-use": "off",
-    "import/no-namespace": "off",
-    "no-unused-vars": "off",
-    "@typescript-eslint/no-unused-vars": "error",
-    "@typescript-eslint/explicit-member-accessibility": [
-      "error",
-      { "accessibility": "no-public" }
-    ],
-    "@typescript-eslint/no-require-imports": "error",
-    "@typescript-eslint/array-type": "error",
-    "@typescript-eslint/await-thenable": "error",
-    "@typescript-eslint/ban-ts-comment": "error",
-    "camelcase": "off",
-    "@typescript-eslint/consistent-type-assertions": "error",
-    "@typescript-eslint/explicit-function-return-type": [
-      "error",
-      { "allowExpressions": true }
-    ],
-    "@typescript-eslint/func-call-spacing": ["error", "never"],
-    "@typescript-eslint/no-array-constructor": "error",
-    "@typescript-eslint/no-empty-interface": "error",
-    "@typescript-eslint/no-explicit-any": "error",
-    "@typescript-eslint/no-extraneous-class": "error",
-    "@typescript-eslint/no-for-in-array": "error",
-    "@typescript-eslint/no-inferrable-types": "error",
-    "@typescript-eslint/no-misused-new": "error",
-    "@typescript-eslint/no-namespace": "error",
-    "@typescript-eslint/no-non-null-assertion": "warn",
-    "@typescript-eslint/no-unnecessary-qualifier": "error",
-    "@typescript-eslint/no-unnecessary-type-assertion": "error",
-    "@typescript-eslint/no-useless-constructor": "error",
-    "@typescript-eslint/no-var-requires": "error",
-    "@typescript-eslint/prefer-for-of": "warn",
-    "@typescript-eslint/prefer-function-type": "warn",
-    "@typescript-eslint/prefer-includes": "error",
-    "@typescript-eslint/prefer-string-starts-ends-with": "error",
-    "@typescript-eslint/promise-function-async": "error",
-    "@typescript-eslint/require-array-sort-compare": "error",
-    "@typescript-eslint/restrict-plus-operands": "error",
-    "@typescript-eslint/type-annotation-spacing": "error",
-    "@typescript-eslint/unbound-method": "error"
-  },
-  "env": {
-    "node": true,
-    "es6": true,
-    "jest/globals": true
-  }
-}
--- a/.prettierignore
+++ b/.prettierignore
@ -1,3 +0,0 @@
-dist/
-lib/
-node_modules/
--- a/.prettierrc.json
+++ b/.prettierrc.json
@ -1,4 +0,0 @@
-{
-  "trailingComma": "all",
-  "proseWrap": "always"
-}
--- a/biome.json
+++ b/biome.json
@ -0,0 +1,31 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.9.2/schema.json",
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": false
+  },
+  "files": {
+    "ignoreUnknown": false,
+    "ignore": ["dist", "lib", "node_modules"]
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space"
+  },
+  "organizeImports": {
+    "enabled": true
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "double",
+      "trailingCommas": "all"
+    }
+  }
+}
--- a/dist/save-cache/index.js
+++ b/dist/save-cache/index.js
@ -82951,7 +82951,7 @@ function saveCache() {
            core.warning("Error retrieving cache key from state.");
            return;
        }
-        else if (matchedKey === cacheKey) {
+        if (matchedKey === cacheKey) {
            core.info(`Cache hit occurred on key ${cacheKey}, not saving cache.`);
            return;
        }
@ -83010,7 +83010,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.githubToken = exports.toolDir = exports.toolBinDir = exports.cacheDependencyGlob = exports.cacheLocalPath = exports.cacheSuffix = exports.enableCache = exports.checkSum = exports.version = void 0;
 const core = __importStar(__nccwpck_require__(2186));
-const path_1 = __importDefault(__nccwpck_require__(1017));
+const node_path_1 = __importDefault(__nccwpck_require__(9411));
 exports.version = core.getInput("version");
 exports.checkSum = core.getInput("checksum");
 exports.enableCache = core.getInput("enable-cache") === "true";
@ -83027,7 +83027,7 @@ function getToolBinDir() {
    }
    if (process.platform === "win32") {
        if (process.env.RUNNER_TEMP !== undefined) {
-            return `${process.env.RUNNER_TEMP}${path_1.default.sep}uv-tool-bin-dir`;
+            return `${process.env.RUNNER_TEMP}${node_path_1.default.sep}uv-tool-bin-dir`;
        }
        throw Error("Could not determine UV_TOOL_BIN_DIR. Please make sure RUNNER_TEMP is set or provide the tool-bin-dir input");
    }
@ -83040,7 +83040,7 @@ function getToolDir() {
    }
    if (process.platform === "win32") {
        if (process.env.RUNNER_TEMP !== undefined) {
-            return `${process.env.RUNNER_TEMP}${path_1.default.sep}uv-tool-dir`;
+            return `${process.env.RUNNER_TEMP}${node_path_1.default.sep}uv-tool-dir`;
        }
        throw Error("Could not determine UV_TOOL_DIR. Please make sure RUNNER_TEMP is set or provide the tool-dir input");
    }
@ -83052,7 +83052,7 @@ function getCacheLocalPath() {
        return cacheLocalPathInput;
    }
    if (process.env.RUNNER_TEMP !== undefined) {
-        return `${process.env.RUNNER_TEMP}${path_1.default.sep}setup-uv-cache`;
+        return `${process.env.RUNNER_TEMP}${node_path_1.default.sep}setup-uv-cache`;
    }
    throw Error("Could not determine UV_CACHE_DIR. Please make sure RUNNER_TEMP is set or provide the cache-local-path input");
 }
@ -83214,6 +83214,14 @@ module.exports = require("node:events");

 /***/ }),

+/***/ 9411:
+/***/ ((module) => {
+
+"use strict";
+module.exports = require("node:path");
+
+/***/ }),
+
 /***/ 4492:
 /***/ ((module) => {

--- a/dist/setup/index.js
+++ b/dist/setup/index.js
@ -87831,7 +87831,7 @@ const cache = __importStar(__nccwpck_require__(7799));
 const glob = __importStar(__nccwpck_require__(8090));
 const core = __importStar(__nccwpck_require__(2186));
 const inputs_1 = __nccwpck_require__(9378);
-const platforms_1 = __nccwpck_require__(6005);
+const platforms_1 = __nccwpck_require__(9945);
 exports.STATE_CACHE_KEY = "cache-key";
 exports.STATE_CACHE_MATCHED_KEY = "cache-matched-key";
 const CACHE_VERSION = "1";
@ -87924,8 +87924,8 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.validateChecksum = validateChecksum;
 exports.isknownVersion = isknownVersion;
-const fs = __importStar(__nccwpck_require__(7147));
-const crypto = __importStar(__nccwpck_require__(6113));
+const fs = __importStar(__nccwpck_require__(7561));
+const crypto = __importStar(__nccwpck_require__(6005));
 const core = __importStar(__nccwpck_require__(2186));
 const known_checksums_1 = __nccwpck_require__(4379);
 function validateChecksum(checkSum, downloadPath, arch, platform, version) {
@ -87935,7 +87935,7 @@ function validateChecksum(checkSum, downloadPath, arch, platform, version) {
            isValid = yield validateFileCheckSum(downloadPath, checkSum);
        }
        else {
-            core.debug(`Checksum not provided. Checking known checksums.`);
+            core.debug("Checksum not provided. Checking known checksums.");
            const key = `${arch}-${platform}-${version}`;
            if (key in known_checksums_1.KNOWN_CHECKSUMS) {
                const knownChecksum = known_checksums_1.KNOWN_CHECKSUMS[`${arch}-${platform}-${version}`];
@ -89916,7 +89916,7 @@ exports.downloadLatest = downloadLatest;
 const core = __importStar(__nccwpck_require__(2186));
 const tc = __importStar(__nccwpck_require__(7784));
 const exec = __importStar(__nccwpck_require__(1514));
-const path = __importStar(__nccwpck_require__(1017));
+const path = __importStar(__nccwpck_require__(9411));
 const checksum_1 = __nccwpck_require__(4622);
 const constants_1 = __nccwpck_require__(8593);
 function downloadLatest(platform, arch, checkSum, githubToken) {
@ -90015,7 +90015,7 @@ exports.tryGetFromToolCache = tryGetFromToolCache;
 exports.downloadVersion = downloadVersion;
 const core = __importStar(__nccwpck_require__(2186));
 const tc = __importStar(__nccwpck_require__(7784));
-const path = __importStar(__nccwpck_require__(1017));
+const path = __importStar(__nccwpck_require__(9411));
 const constants_1 = __nccwpck_require__(8593);
 const checksum_1 = __nccwpck_require__(4622);
 const github = __importStar(__nccwpck_require__(5438));
@ -90124,11 +90124,11 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 const core = __importStar(__nccwpck_require__(2186));
-const path = __importStar(__nccwpck_require__(1017));
+const path = __importStar(__nccwpck_require__(9411));
 const download_version_1 = __nccwpck_require__(8841);
 const restore_cache_1 = __nccwpck_require__(1898);
 const download_latest_1 = __nccwpck_require__(5871);
-const platforms_1 = __nccwpck_require__(6005);
+const platforms_1 = __nccwpck_require__(9945);
 const inputs_1 = __nccwpck_require__(9378);
 function run() {
    return __awaiter(this, void 0, void 0, function* () {
@ -90277,7 +90277,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.githubToken = exports.toolDir = exports.toolBinDir = exports.cacheDependencyGlob = exports.cacheLocalPath = exports.cacheSuffix = exports.enableCache = exports.checkSum = exports.version = void 0;
 const core = __importStar(__nccwpck_require__(2186));
-const path_1 = __importDefault(__nccwpck_require__(1017));
+const node_path_1 = __importDefault(__nccwpck_require__(9411));
 exports.version = core.getInput("version");
 exports.checkSum = core.getInput("checksum");
 exports.enableCache = core.getInput("enable-cache") === "true";
@ -90294,7 +90294,7 @@ function getToolBinDir() {
    }
    if (process.platform === "win32") {
        if (process.env.RUNNER_TEMP !== undefined) {
-            return `${process.env.RUNNER_TEMP}${path_1.default.sep}uv-tool-bin-dir`;
+            return `${process.env.RUNNER_TEMP}${node_path_1.default.sep}uv-tool-bin-dir`;
        }
        throw Error("Could not determine UV_TOOL_BIN_DIR. Please make sure RUNNER_TEMP is set or provide the tool-bin-dir input");
    }
@ -90307,7 +90307,7 @@ function getToolDir() {
    }
    if (process.platform === "win32") {
        if (process.env.RUNNER_TEMP !== undefined) {
-            return `${process.env.RUNNER_TEMP}${path_1.default.sep}uv-tool-dir`;
+            return `${process.env.RUNNER_TEMP}${node_path_1.default.sep}uv-tool-dir`;
        }
        throw Error("Could not determine UV_TOOL_DIR. Please make sure RUNNER_TEMP is set or provide the tool-dir input");
    }
@ -90319,7 +90319,7 @@ function getCacheLocalPath() {
        return cacheLocalPathInput;
    }
    if (process.env.RUNNER_TEMP !== undefined) {
-        return `${process.env.RUNNER_TEMP}${path_1.default.sep}setup-uv-cache`;
+        return `${process.env.RUNNER_TEMP}${node_path_1.default.sep}setup-uv-cache`;
    }
    throw Error("Could not determine UV_CACHE_DIR. Please make sure RUNNER_TEMP is set or provide the cache-local-path input");
 }
@ -90327,7 +90327,7 @@ function getCacheLocalPath() {

 /***/ }),

-/***/ 6005:
+/***/ 9945:
 /***/ ((__unused_webpack_module, exports) => {

 "use strict";
@ -90473,6 +90473,14 @@ module.exports = require("net");

 /***/ }),

+/***/ 6005:
+/***/ ((module) => {
+
+"use strict";
+module.exports = require("node:crypto");
+
+/***/ }),
+
 /***/ 5673:
 /***/ ((module) => {

@ -90481,6 +90489,22 @@ module.exports = require("node:events");

 /***/ }),

+/***/ 7561:
+/***/ ((module) => {
+
+"use strict";
+module.exports = require("node:fs");
+
+/***/ }),
+
+/***/ 9411:
+/***/ ((module) => {
+
+"use strict";
+module.exports = require("node:path");
+
+/***/ }),
+
 /***/ 4492:
 /***/ ((module) => {

--- a/dist/update-known-checksums/index.js
+++ b/dist/update-known-checksums/index.js
@ -32708,24 +32708,24 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.updateChecksums = updateChecksums;
-const fs_1 = __nccwpck_require__(7147);
+const node_fs_1 = __nccwpck_require__(7561);
 const tc = __importStar(__nccwpck_require__(7784));
 function updateChecksums(filePath, downloadUrls) {
    return __awaiter(this, void 0, void 0, function* () {
-        yield fs_1.promises.rm(filePath);
-        yield fs_1.promises.appendFile(filePath, "// AUTOGENERATED_DO_NOT_EDIT\nexport const KNOWN_CHECKSUMS: {[key: string]: string} = {\n");
+        yield node_fs_1.promises.rm(filePath);
+        yield node_fs_1.promises.appendFile(filePath, "// AUTOGENERATED_DO_NOT_EDIT\nexport const KNOWN_CHECKSUMS: {[key: string]: string} = {\n");
        let firstLine = true;
        for (const downloadUrl of downloadUrls) {
            const content = yield downloadAssetContent(downloadUrl);
            const checksum = content.split(" ")[0].trim();
            const key = getKey(downloadUrl);
            if (!firstLine) {
-                yield fs_1.promises.appendFile(filePath, ",\n");
+                yield node_fs_1.promises.appendFile(filePath, ",\n");
            }
-            yield fs_1.promises.appendFile(filePath, `  '${key}':\n    '${checksum}'`);
+            yield node_fs_1.promises.appendFile(filePath, `  '${key}':\n    '${checksum}'`);
            firstLine = false;
        }
-        yield fs_1.promises.appendFile(filePath, "}\n");
+        yield node_fs_1.promises.appendFile(filePath, "}\n");
    });
 }
 function getKey(downloadUrl) {
@ -32739,7 +32739,7 @@ function getKey(downloadUrl) {
 function downloadAssetContent(downloadUrl) {
    return __awaiter(this, void 0, void 0, function* () {
        const downloadPath = yield tc.downloadTool(downloadUrl);
-        const content = yield fs_1.promises.readFile(downloadPath, "utf8");
+        const content = yield node_fs_1.promises.readFile(downloadPath, "utf8");
        return content;
    });
 }
@ -32940,6 +32940,14 @@ module.exports = require("node:events");

 /***/ }),

+/***/ 7561:
+/***/ ((module) => {
+
+"use strict";
+module.exports = require("node:fs");
+
+/***/ }),
+
 /***/ 4492:
 /***/ ((module) => {

--- a/package-lock.json
+++ b/package-lock.json
--- a/package.json
+++ b/package.json
@ -6,9 +6,9 @@
  "main": "dist/index.js",
  "scripts": {
    "build": "tsc",
-    "format": "prettier --write .",
-    "format-check": "prettier --check .",
-    "lint": "eslint src/**/*.ts --fix",
+    "format": "biome format --fix",
+    "format-check": "biome format",
+    "lint": "biome lint --fix",
    "package": "ncc build -o dist/setup src/setup-uv.ts && ncc build -o dist/save-cache src/save-cache.ts && ncc build -o dist/update-known-checksums src/update-known-checksums.ts",
    "test": "jest",
    "act": "act pull_request -W .github/workflows/test.yml --container-architecture linux/amd64 -s GITHUB_TOKEN=\"$(gh auth token)\"",
@ -19,12 +19,7 @@
    "type": "git",
    "url": "git+https://github.com/astral-sh/setup-uv.git"
  },
-  "keywords": [
-    "actions",
-    "python",
-    "setup",
-    "uv"
-  ],
+  "keywords": ["actions", "python", "setup", "uv"],
  "author": "@eifinger",
  "license": "MIT",
  "dependencies": {
@ -38,19 +33,12 @@
    "@octokit/rest": "^21.0.2"
  },
  "devDependencies": {
+    "@biomejs/biome": "1.9.2",
    "@types/node": "^22.7.3",
    "@types/semver": "^7.5.8",
-    "@typescript-eslint/eslint-plugin": "^7.15.0",
-    "@typescript-eslint/parser": "^7.18.0",
    "@vercel/ncc": "^0.38.1",
-    "eslint": "^8.57.1",
-    "eslint-plugin-github": "^5.0.2",
-    "eslint-plugin-import": "^2.30.0",
-    "eslint-plugin-jest": "^28.8.3",
-    "eslint-plugin-prettier": "^5.2.1",
    "jest": "^29.7.0",
    "js-yaml": "^4.1.0",
-    "prettier": "^3.3.3",
    "ts-jest": "^29.2.5",
    "typescript": "^5.6.2"
  }
--- a/src/download/checksum/checksum.ts
+++ b/src/download/checksum/checksum.ts
@ -1,9 +1,9 @@
-import * as fs from "fs";
-import * as crypto from "crypto";
+import * as fs from "node:fs";
+import * as crypto from "node:crypto";

 import * as core from "@actions/core";
 import { KNOWN_CHECKSUMS } from "./known-checksums";
-import { Architecture, Platform } from "../../utils/platforms";
+import type { Architecture, Platform } from "../../utils/platforms";

 export async function validateChecksum(
  checkSum: string | undefined,
@ -16,7 +16,7 @@ export async function validateChecksum(
  if (checkSum !== undefined && checkSum !== "") {
    isValid = await validateFileCheckSum(downloadPath, checkSum);
  } else {
-    core.debug(`Checksum not provided. Checking known checksums.`);
+    core.debug("Checksum not provided. Checking known checksums.");
    const key = `${arch}-${platform}-${version}`;
    if (key in KNOWN_CHECKSUMS) {
      const knownChecksum = KNOWN_CHECKSUMS[`${arch}-${platform}-${version}`];
--- a/src/download/checksum/update-known-checksums.ts
+++ b/src/download/checksum/update-known-checksums.ts
@ -1,4 +1,4 @@
-import { promises as fs } from "fs";
+import { promises as fs } from "node:fs";
 import * as tc from "@actions/tool-cache";
 export async function updateChecksums(
  filePath: string,
--- a/src/download/download-latest.ts
+++ b/src/download/download-latest.ts
@ -1,8 +1,8 @@
 import * as core from "@actions/core";
 import * as tc from "@actions/tool-cache";
 import * as exec from "@actions/exec";
-import * as path from "path";
-import { Architecture, Platform } from "../utils/platforms";
+import * as path from "node:path";
+import type { Architecture, Platform } from "../utils/platforms";
 import { validateChecksum } from "./checksum/checksum";
 import { OWNER, REPO, TOOL_CACHE_NAME } from "../utils/constants";

--- a/src/download/download-version.ts
+++ b/src/download/download-version.ts
@ -1,8 +1,8 @@
 import * as core from "@actions/core";
 import * as tc from "@actions/tool-cache";
-import * as path from "path";
+import * as path from "node:path";
 import { OWNER, REPO, TOOL_CACHE_NAME } from "../utils/constants";
-import { Architecture, Platform } from "../utils/platforms";
+import type { Architecture, Platform } from "../utils/platforms";
 import { validateChecksum } from "./checksum/checksum";
 import * as github from "@actions/github";

--- a/src/save-cache.ts
+++ b/src/save-cache.ts
@ -26,7 +26,8 @@ async function saveCache(): Promise<void> {
  if (!cacheKey) {
    core.warning("Error retrieving cache key from state.");
    return;
-  } else if (matchedKey === cacheKey) {
+  }
+  if (matchedKey === cacheKey) {
    core.info(`Cache hit occurred on key ${cacheKey}, not saving cache.`);
    return;
  }
--- a/src/setup-uv.ts
+++ b/src/setup-uv.ts
@ -1,5 +1,5 @@
 import * as core from "@actions/core";
-import * as path from "path";
+import * as path from "node:path";
 import {
  downloadVersion,
  tryGetFromToolCache,
@ -8,10 +8,10 @@ import { restoreCache } from "./cache/restore-cache";

 import { downloadLatest } from "./download/download-latest";
 import {
-  Architecture,
+  type Architecture,
  getArch,
  getPlatform,
-  Platform,
+  type Platform,
 } from "./utils/platforms";
 import {
  cacheLocalPath,
--- a/src/utils/inputs.ts
+++ b/src/utils/inputs.ts
@ -1,5 +1,5 @@
 import * as core from "@actions/core";
-import path from "path";
+import path from "node:path";

 export const version = core.getInput("version");
 export const checkSum = core.getInput("checksum");